[lexical][lexical-playground] Fix: Use the fallback matching for number keys in keyboard shortcuts#8361
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Apr 16, 2026
etrepum
left a comment
Collaborator
There was a problem hiding this comment.
it would be cleaner if this was done in one place instead of two, e.g. isFormatHeading could be getFormatHeading which would tell you which heading it was (or undefined)
etrepum
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a fallback check for number keys to the
isExactShortcutMatchfunction. On macOS, the English keyboard layout produces the following characters when the Option key is pressed in combination with numbers:1→¡2→™£→£This became apparent after the changes in this PR #8260, as the keyboard shortcuts for headings in the playground stopped working
Test plan
Before
The Option key didn't work with numbers on the English keyboard layout in macOS
After
Support for the Option + Num hotkeys has been added for macOS. Alternative keyboard layouts, such as Dvorak or other languages, continue working