[lexical-react] Bug Fix: Prevent error when editorRef is null#8329
Conversation
editorRef is allowed to be null and must be checked on this type before value allocation.
|
Hi @Jimmy89! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
etrepum
left a comment
There was a problem hiding this comment.
It looks like editorRef is not allowed to be null according to TypeScript but being a little more defensive here doesn't hurt
Description
editorRef is allowed to be null and must be checked on this type before value allocation. This PR adds that check.
Closes #8327
Test plan
Add a LexicalEditor with a LexicalEditorRefPlugin where editorRef is value
null.Old situation: error
New situation: line of error skipped