Skip to content

fix(idea_plugin): fix custom comma management strategy not being applied#593

Closed
tKe wants to merge 2 commits into
facebook:mainfrom
tKe:fix/idea_plugin/custom-comma-management-strategy-not-applied
Closed

fix(idea_plugin): fix custom comma management strategy not being applied#593
tKe wants to merge 2 commits into
facebook:mainfrom
tKe:fix/idea_plugin/custom-comma-management-strategy-not-applied

Conversation

@tKe

@tKe tKe commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

The ktfmt settings controls were putting the toString of the TrailingCommaManagementStrategy instead of the .name which was expected by the formatting options creation code.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2026

@hick209 hick209 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you validate this works and fixes things?

Also can you update the CHANGELOG.md before we pull this in?

@tKe

tKe commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

How did you validate this works and fixes things?

This has been tested and validated in the 2022.3 build using the runIde task. I've also built and used it locally in the current 2026.1 EAP.

Also can you update the CHANGELOG.md before we pull this in?

Done

@meta-codesync

meta-codesync Bot commented Feb 3, 2026

Copy link
Copy Markdown

@hick209 has imported this pull request. If you are a Meta employee, you can view this in D92171530.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync

meta-codesync Bot commented Feb 4, 2026

Copy link
Copy Markdown

@hick209 merged this pull request in 67e372b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants