fix: editorconfig not found for relative paths#582
Closed
tKe wants to merge 4 commits intofacebook:mainfrom
Closed
fix: editorconfig not found for relative paths#582tKe wants to merge 4 commits intofacebook:mainfrom
tKe wants to merge 4 commits intofacebook:mainfrom
Conversation
queryProperties walks up the provided path to find `.editorconfig` files. In the common case of a `.editorconfig` in the root of the repo or project, when running `ktfmt` on a path like `src/main/kotlin/MyFile.kt` it will stop looking in `src` as `src` has no "parent" and not find any `.editorconfig`. Using a path like `./src/main/kotlin/MyFile.kt` will stop at `.` and find `./.editorconfig`. By using the absolute path of the file, it'll walk all ancestors until it finds a `.editorconfig` with `root = true` as expected.
hick209
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the common case of a
.editorconfigin the root of the repo orproject, when running
ktfmton a path likesrc/main/kotlin/MyFile.ktit will stop looking in
srcassrchas no "parent" and not find any.editorconfig. Using a path like./src/main/kotlin/MyFile.ktwillstop at
.and find./.editorconfig.By using the absolute path of the file, it'll walk all ancestors until
it finds a
.editorconfigwithroot = trueas expected.I've also added
ktfmt_trailing_comma_management_strategyto the example editorconfigs and fixed an issue with the gradle build supporting configuration-cache. I'm happy to move either/both of these to separate PRs if required.