Conversation
|
Hi @vRallev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2347325 to
682c3a5
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thanks for contributing! If you don't mind (or I don't do it first) would you mind updating |
Specify an explicit import layout instead of relying on the Kotlin Official default. The Kotlin Official style uses `ij_kotlin_imports_layout = *,java.**,javax.**,kotlin.**,^`. The new explicit import layout changes it to how ktfmt formats code. `.editorconfig-kotlinlang` has already applied the same setting.
682c3a5 to
fbca6fc
Compare
I updated the CHANGELOG. |
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Specify an explicit import layout instead of relying on the Kotlin Official default. The Kotlin Official style uses
ij_kotlin_imports_layout = *,java.**,javax.**,kotlin.**,^. The new explicit import layout changes it to how ktfmt formats code..editorconfig-kotlinlanghas already applied the same setting.