feat: --enable-editorconfig flag and .editorconfig support#570
Closed
tKe wants to merge 7 commits intofacebook:mainfrom
Closed
feat: --enable-editorconfig flag and .editorconfig support#570tKe wants to merge 7 commits intofacebook:mainfrom
tKe wants to merge 7 commits intofacebook:mainfrom
Conversation
Contributor
Author
Contributor
|
That's awesome! Thanks for working on it |
hick209
approved these changes
Dec 10, 2025
cortinico
approved these changes
Dec 10, 2025
Contributor
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
hick209
reviewed
Dec 10, 2025
Contributor
hick209
left a comment
There was a problem hiding this comment.
Overall looks good.
Just a few minor tweaks and we can ship this.
core/src/main/java/com/facebook/ktfmt/cli/EditorConfigResolver.kt
Outdated
Show resolved
Hide resolved
hick209
requested changes
Dec 10, 2025
Contributor
hick209
left a comment
There was a problem hiding this comment.
Also, please update the CHANGELOG.md. It can be something like
- ktfmt can pull formatting configs from editor config files (https://github.com/facebook/ktfmt/pull/570)
hick209
approved these changes
Dec 17, 2025
Contributor
|
There are some minor things that I'll fix myself here before landing. Awesome work @tKe, thanks for contributing to making ktfmt better for everyone |
This was referenced Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #45