-
Notifications
You must be signed in to change notification settings - Fork 652
Fix for missing classes required on executeStopOnVMShutdown:true #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Thanks for spotting this! An alternative solution would be to remove Guava altogether from the code base, it doesn't add many benefits (except causing issues like these :) @rohanKanojia wdyt ? On the other hand, this is a quick fix without any side-effects asfais, so would be happy to merge it, too. |
|
Sounds like a better fix indeed. It was barely used for things that don't even need it. Great plugin by the way. |
…ric8io#1833) Co-authored-by: Aleks.I <aleksandar.ivanov@observis.fi>
Bumps io.fabric8:docker-maven-plugin from 0.30.0 to 0.48.0. ## Release notes Sourced from io.fabric8:docker-maven-plugin's releases. 0.48.0 (2025-11-17) Allow saving multiple images in docker:save using new parameters saveNames and saveAliases. #1891 Fixed compatibility with Docker 29+ which requires minimum API version 1.44 Fixed IP address parsing to support both legacy and new Docker API schema formats (#1887) 0.47.0 (2025-11-01) Support for user namespace mode (1881) Bump Jib Core to v0.27.3 (1879) Bump Jnr UnixSocket to v0.38.23 (1880) Drop Plexus DI, switch to plexus-utils, update m-assembly-p and deps, verified with Maven 4 (1851) dmp:tag should skip <image>s with no <build> (1871) buildArchiveOnly with a path still builds the image (1863) Add skip tag to the image level by <skipTag> (1787) v0.46.0 (2025-04-07) What's Changed Docker-compose healthcheck configuration support (1825) Docker container wait timeout default value made configurable using startContainerWaitTimeout configuration option (1825) Respect network configuration in POM and with property docker.build.network or system property docker.network.mode in docker buildx 1850) Fix case sensitivity issue in builder name lookup by converting builderName to lowercase, ensuring compatibility across file systems (1847) Move off direct SecDispatcher use #1848 New Contributors @Smiche made their first contribution in fabric8io/docker-maven-plugin#1833 @arend-von-reinersdorff made their first contribution in fabric8io/docker-maven-plugin#1837 @cstamas made their first contribution in fabric8io/docker-maven-plugin#1849 @michaelmejaeger made their first contribution in fabric8io/docker-maven-plugin#1850 @Amitrei made their first contribution in fabric8io/docker-maven-plugin#1847 Full Changelog: fabric8io/docker-maven-plugin@v0.45.1...v0.46.0 0.45.1 (2024-09-29) Make copy docker-buildx binary to temporary config directory work on windows too (1819) Pull FROM images in relative path Dockerfiles (1823) New Contributors @tusharwebd made their first contribution in fabric8io/docker-maven-plugin#1816 @jrnorth made their first contribution in fabric8io/docker-maven-plugin#1824 @derHeinz made their first contribution in fabric8io/docker-maven-plugin#1819 Full Changelog: fabric8io/docker-maven-plugin@v0.45.0...v0.45.1 0.45.0 (2024-07-27) Automatically create parent directories of portPropertyFile path (1761) Use complete image id in DockerAccessWithHcClient while fetching image id (1764) Add skip tag to the image level by <skipTag> (1787) Remove usage of AnsiConsole (1791) ... (truncated) ## Changelog Sourced from io.fabric8:docker-maven-plugin's changelog. ChangeLog 0.49-SNAPSHOT: 0.48.0 (2025-11-17): Allow saving multiple images in docker:save using new parameters saveNames and saveAliases. Fixed compatibility with Docker 29+ which requires minimum API version 1.44 Fixed IP address parsing to support both legacy and new Docker API schema formats (#1887) 0.47.0 (2025-11-01): Support for user namespace mode (1881) Bump Jib Core to v0.27.3 (1879) Bump Jnr UnixSocket to v0.38.23 (1880) Drop Plexus DI, switch to plexus-utils, update m-assembly-p and deps, verified with Maven 4 (1851) dmp:tag should skip <image>s with no <build> (1871) buildArchiveOnly with a path still builds the image (1863) Add skip tag to the image level by <skipTag> (1787) 0.46.0 (2025-04-06): Docker-compose healthcheck configuration support (1825) Docker container wait timeout default value made configurable using startContainerWaitTimeout configuration option (1825) Respect network configuration in POM and with property docker.build.network or system property docker.network.mode in docker buildx 1850) Fix case sensitivity issue in builder name lookup by converting builderName to lowercase, ensuring compatibility across file systems (1847) 0.45.1 (2024-09-29): Make copy docker-buildx binary to temporary config directory work on windows too (1819) Pull FROM images in relative path Dockerfiles (1823) 0.45.0 (2024-07-27): Automatically create parent directories of portPropertyFile path (1761) Use complete image id in DockerAccessWithHcClient while fetching image id (1764) Add skip tag to the image level by <skipTag> (1787) Remove usage of AnsiConsole (1791) Gracefully handle 404 when removing container (1793) Added support for platform attribute of a container in the docker-compose configuration. Image Build Config BuildArgs should be passed while pulling images (1756) docker:push failed with build ARG in FROM (1778) Add the possibility to give secret to buildx build (1798 FROM can reference ARG that references other ARG (1800) 0.44.0 (2024-02-17): Add new option "useDefaultExclusion" for build configuration to handle exclusion of hidden files (1708) The option is now propagated down to the buildx command, if it is set in the section. (1717) Fix Buildx build with Dockerfile outside of the Docker build context directory (1721) Add support setting driverOpts for buildx (1704) Multi-Architecture push is not sending pull registry auth credentials (1709) Adding support for --cacheFrom and --cacheTo buildX arguments (1621) Add support for using maven/system properties for an ARG used as the FROM image in a dockerfile (1731) Revert workaround for checking docker version for checking whether to add docker --config flag or not. (1754) Add a workaround to copy docker-buildx binary to temporary config directory created for docker buildx build. This seems to make docker recognize buildx even after config override. (1754) Fix Windows volume bindings for Rancher, Podman and Windows-based containers (1719) ... (truncated) ## Commits 6a078ce [RELEASE] Update project version to v0.48.0 5aa67c2 Allow saving multiple images in docker:save using new parameters list saveNam 19f2ac6 fix: Replace all unavailable openjdk images with eclipse-temurin:21-jre-alpine deba500 fix: Replace unavailable openjdk:21-slim with eclipse-temurin:21-jre-alpine 17c081e fix: Add Docker 29+(API 1.44+) compatibility support 960cc6a ci: update release workflow to use Maven Central credentials and server ID d2ba73d [RELEASE] Prepare for next development iteration ec9ae21 [RELEASE] Update project version to v0.47.0 e32846c Add support for user namespace mode 0e8c88e chore (deps) : Bump test dependencies to latest available versions Additional commits viewable in compare view  GitHub2Gerrit Metadata: Mode: squash Topic: GH-lfit-sandbox-30 Digest: 2e3044ab1a2f Issue-ID: CIMAN-33 Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lfit.gh2gerrit <releng+lfit-gh2gerrit@linuxfoundation.org> Change-Id: I64ed9af7564ef7dfecff1f725fced380ea8049ef GitHub-PR: #30 GitHub-Hash: 7a4703e9dc146a04



I encountered the following issue:

Using:
Adding the two required classes to the Class loader resolved the issue. I didn't go in too deep why that check using Strings occurs.
Here's the execution config which lead to this: