[refactor] Use range() function instead of string increment#367
Merged
ezyang merged 1 commit intoezyang:masterfrom Feb 23, 2023
Girgias:range-insteadof-string-inc
Merged
[refactor] Use range() function instead of string increment#367ezyang merged 1 commit intoezyang:masterfrom Girgias:range-insteadof-string-inc
ezyang merged 1 commit intoezyang:masterfrom
Girgias:range-insteadof-string-inc
Conversation
This was found during the analysis for https://wiki.php.net/rfc/saner-inc-dec-operators I don't know what is the minimal version targeted, so the line which defines ``$c`` may need to be changes to use ``array_merge()``
ezyang
reviewed
Feb 23, 2023
| $c = array_merge($l, $u, $d, $b); | ||
| // Concatenate all valid characters into a string | ||
| // Use '_- ' as an initial value | ||
| $this->mask = array_reduce($c, function ($carry, $value) { |
ezyang
approved these changes
Feb 23, 2023
|
At the end, we could more simply do |
|
邮件已收到，谢谢！
|
|
🎉 This PR is included in version 4.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was found during the analysis for https://wiki.php.net/rfc/saner-inc-dec-operators
I don't know what is the minimal version targeted, so the line which definesCI is telling me it's PHP-5.6 so that's clear.$cmay need to be changes to usearray_merge()