Skip to content

fix: put back the expires into the github generator#5472

Merged
moolen merged 1 commit intoexternal-secrets:mainfrom
Skarlso:fix-github-action-generator
Oct 16, 2025
Merged

fix: put back the expires into the github generator#5472
moolen merged 1 commit intoexternal-secrets:mainfrom
Skarlso:fix-github-action-generator

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 16, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #5471

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@moolen moolen merged commit b3492fa into external-secrets:main Oct 16, 2025
28 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
…#5472)

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

GithubAccessToken generator fails with "401 Bad credentials" in v0.20.3

2 participants