Skip to content

docs: remove jwt token authentication option from STSSessionToken generator#5468

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
liununu:main
Oct 14, 2025
Merged

docs: remove jwt token authentication option from STSSessionToken generator#5468
Skarlso merged 1 commit intoexternal-secrets:mainfrom
liununu:main

Conversation

@liununu
Copy link
Copy Markdown
Contributor

@liununu liununu commented Oct 14, 2025

Problem Statement

STSSessionToken generator code snippet is outdated, and confuses people

Related Issue

#5026

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@liununu
docs: remove jwt token authentication option from STSSessionToken gen…
be91823 
…erator

Signed-off-by: liununu <liununu5@gmail.com>
@github-actions github-actions bot added kind/documentation Categorizes issue or PR as related to documentation. size/xs labels Oct 14, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@liununu
Copy link
Copy Markdown
Contributor Author

liununu commented Oct 14, 2025

@Skarlso Could you have a review on this, to remove the legacy jwt auth option from code snippet.

BTW do we have any plan regarding the new way to exchange AWS credential by IRSA

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Oct 14, 2025

BTW do we have any plan regarding

I, personally, don't. :)

@Skarlso Skarlso merged commit dda7b4c into external-secrets:main Oct 14, 2025
28 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
@liununu @SamuelMolling
docs: remove jwt token authentication option from STSSessionToken gen…
7fc9c9f 
…erator (external-secrets#5468)

Signed-off-by: liununu <liununu5@gmail.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

Assignees

No one assigned

Labels

kind/documentation Categorizes issue or PR as related to documentation. size/xs

Projects

External Secrets
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liununu @Skarlso