Skip to content

fix: Webhook provider PushSecret not working#5445

Merged
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:fix-push-secret-on-webhook
Oct 17, 2025
Merged

fix: Webhook provider PushSecret not working#5445
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:fix-push-secret-on-webhook

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 10, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #5408

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. size/s labels Oct 10, 2025
@Skarlso Skarlso force-pushed the fix-push-secret-on-webhook branch from cebda46 to dd3f669 Compare October 10, 2025 10:34
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
@Skarlso Skarlso force-pushed the fix-push-secret-on-webhook branch from dd3f669 to 3959882 Compare October 10, 2025 10:43
@github-actions github-actions bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 10, 2025
Skarlso and others added 2 commits October 17, 2025 20:32
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit 2e5e73e into external-secrets:main Oct 17, 2025
30 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
* fix: Webhook provider PushSecret not working

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

* removed the customizable delete operation

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. size/m size/s

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Webhook provider PushSecret not working

2 participants