fix: use GetClientCertificate in Vault Auth#5441
Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom Oct 17, 2025
Merged
fix: use GetClientCertificate in Vault Auth#5441Skarlso merged 3 commits intoexternal-secrets:mainfrom
Skarlso merged 3 commits intoexternal-secrets:mainfrom
Conversation
03f4ef6 to
7453aaf
Compare
Skarlso
reviewed
Oct 10, 2025
b5028f2 to
e7839e5
Compare
Contributor
Author
|
@Skarlso ready for review 🙏 |
Skarlso
reviewed
Oct 14, 2025
04f413b to
684ea46
Compare
684ea46 to
ee150cb
Compare
Signed-off-by: Zbigniew Mandziejewicz <shaxbee@gmail.com>
Signed-off-by: Zbigniew Mandziejewicz <shaxbee@gmail.com>
ee150cb to
9cc4868
Compare
Contributor
Author
|
@Skarlso rebased and ready for review |
Contributor
|
/ok-to-test sha=9cc48688139f7d1daa2b531bf331b980c8c8607f |
Contributor
Contributor
|
/ok-to-test sha=9cc48688139f7d1daa2b531bf331b980c8c8607f |
Contributor
Skarlso
approved these changes
Oct 17, 2025
|
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
* fix: use GetClientCertificate in Vault Auth Signed-off-by: Zbigniew Mandziejewicz <shaxbee@gmail.com> * fix: use %T for type name Signed-off-by: Zbigniew Mandziejewicz <shaxbee@gmail.com> --------- Signed-off-by: Zbigniew Mandziejewicz <shaxbee@gmail.com> Co-authored-by: Gergely Brautigam <skarlso777@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Statement
Certificate does not get presented to Vault Auth, unless forced with
GetClientCertificate.This is also how vault client is authenticating mTLS: https://github.com/hashicorp/vault/blob/df563db795d6e95e7695e0df2ede069f6540e2cd/api/client.go#L350
When using cert with different intermediate than Vault Server we get following error:
Proposed Changes
Use
tls.Config.GetClientCertificateinstead oftls.Config.Certificates.We've tested with @jasonjoo2010 this against our infra and it fixes the issue.
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable