Skip to content

fix: make port in the schema file either a string of an integer#5439

Merged
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:fix-http-port
Oct 9, 2025
Merged

fix: make port in the schema file either a string of an integer#5439
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:fix-http-port

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 9, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #5437

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@Skarlso
fix: make port in the schema file either a string of an integer
b500467 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. size/m labels Oct 9, 2025
moolen
moolen previously approved these changes Oct 9, 2025
View reviewed changes
Skarlso and others added 3 commits October 9, 2025 09:13
@Skarlso
Merge branch 'main' into fix-http-port
7450e59
@Skarlso
run make check-diff
18c6a2d 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Merge branch 'fix-http-port' of github.com:Skarlso/external-secrets i…
8411545 
…nto fix-http-port
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 9, 2025

/ok-to-test sha=a4e4bdca3632b5b67c1c9cfe661994d086633681

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 9, 2025

[Bot] - ✅ e2e for a4e4bdca3632b5b67c1c9cfe661994d086633681 passed

@Skarlso Skarlso merged commit f340ba9 into external-secrets:main Oct 9, 2025
29 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
@Skarlso @SamuelMolling
fix: make port in the schema file either a string of an integer (exte…
b12f782 
…rnal-secrets#5439)

* fix: make port in the schema file either a string of an integer

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* run make check-diff

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riccardomc riccardomc riccardomc approved these changes

@moolen moolen moolen left review comments

Assignees

No one assigned

Labels

kind/bug Categorizes issue or PR as related to a bug. size/m

Projects

External Secrets
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

livenessProbe deployment issue with httpGet port

3 participants

@Skarlso @moolen @riccardomc