Skip to content

docs(release): Resolve incorrect references in documentation samples#5431

Merged
Skarlso merged 4 commits intoexternal-secrets:mainfrom
blast-hardcheese:patch-1
Oct 8, 2025
Merged

docs(release): Resolve incorrect references in documentation samples#5431
Skarlso merged 4 commits intoexternal-secrets:mainfrom
blast-hardcheese:patch-1

Conversation

@blast-hardcheese
Copy link
Copy Markdown
Contributor

Problem Statement

Trying to interpret the docs was tricky, it makes more sense this way.

Related Issue

Fixes #...

Proposed Changes

Simple docs change, intended to increase intelligibility.

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Trying to interpret the docs was tricky, it makes more sense this way.

Signed-off-by: Devon Stewart <blast@hardchee.se>
Signed-off-by: Devon Stewart <blast@hardchee.se>
Signed-off-by: Devon Stewart <blast@hardchee.se>
@github-actions github-actions bot added area/release Issues / Pull Requests related to releases kind/documentation Categorizes issue or PR as related to documentation. size/xs labels Oct 7, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 8, 2025

@Skarlso Skarlso merged commit 8f0a921 into external-secrets:main Oct 8, 2025
7 checks passed
@blast-hardcheese blast-hardcheese deleted the patch-1 branch October 8, 2025 19:25
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
…xternal-secrets#5431)

* Fix broken docs example

Trying to interpret the docs was tricky, it makes more sense this way.

Signed-off-by: Devon Stewart <blast@hardchee.se>

* Update full-pushsecret-no-key-no-property.yaml

Signed-off-by: Devon Stewart <blast@hardchee.se>

* Update full-pushsecret.yaml

Signed-off-by: Devon Stewart <blast@hardchee.se>

---------

Signed-off-by: Devon Stewart <blast@hardchee.se>
Co-authored-by: Gergely Brautigam <skarlso777@gmail.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release Issues / Pull Requests related to releases kind/documentation Categorizes issue or PR as related to documentation. size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants