docs: Update scaleway json doc#5429
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom Oct 8, 2025
RobinFrcd:update-scaleway-json-doc
Merged
docs: Update scaleway json doc#5429Skarlso merged 2 commits intoexternal-secrets:mainfrom RobinFrcd:update-scaleway-json-doc
Skarlso merged 2 commits intoexternal-secrets:mainfrom
RobinFrcd:update-scaleway-json-doc
Conversation
Skarlso
approved these changes
Oct 8, 2025
Contributor
|
@RobinFrcd Ah, you need to sign your commit please. :) |
Signed-off-by: RobinFrcd <29704178+RobinFrcd@users.noreply.github.com>
|
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
Signed-off-by: RobinFrcd <29704178+RobinFrcd@users.noreply.github.com> Co-authored-by: Gergely Brautigam <skarlso777@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just update the doc regarding #5428
As JSON is, in fact, already supported by the Scaleway's provider. Cf. the tests https://github.com/external-secrets/external-secrets/blob/b466ca0d14989f0b8c370b89b1e7d99fbb30cd3b/pkg/provider/scaleway/client_test.go#L155C4-L155C35