Skip to content

docs: add note on Vault 1.21 audience requirement for roles#5411

Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom
AddRain1:docs/kubernetes-audience-note
Oct 5, 2025
Merged

docs: add note on Vault 1.21 audience requirement for roles#5411
Skarlso merged 3 commits intoexternal-secrets:mainfrom
AddRain1:docs/kubernetes-audience-note

Conversation

@AddRain1
Copy link
Copy Markdown
Contributor

@AddRain1 AddRain1 commented Oct 4, 2025

Problem Statement

Documented that roles require an audience in Vault 1.21+

Related Issue

Fixes #1723

Proposed Changes

  • Added a documentation note about Vault 1.20+ behavior:
    • Roles without an audience trigger warnings in Vault 1.20.
    • Roles without an audience fail authentication in Vault 1.21+.

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@github-actions github-actions bot added area/security Issues / Pull Requests related to security kind/documentation Categorizes issue or PR as related to documentation. size/s labels Oct 4, 2025
Signed-off-by: AddRain1 <adriankvo22@gmail.com>
Signed-off-by: AddRain1 <adriankvo22@gmail.com>
Signed-off-by: AddRain1 <adriankvo22@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 4, 2025

@AddRain1 AddRain1 changed the title docs(security): add note on Vault 1.21 audience requirement for roles docs: add note on Vault 1.21 audience requirement for roles Oct 4, 2025
@Skarlso Skarlso merged commit 7329e8c into external-secrets:main Oct 5, 2025
32 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
…-secrets#5411)

* docs(vault): add audience requirement for roles in 1.21+

Signed-off-by: AddRain1 <adriankvo22@gmail.com>

* docs(vault): update code block to use yaml syntax highlighting

Signed-off-by: AddRain1 <adriankvo22@gmail.com>

* docs(vault): update code spacing

Signed-off-by: AddRain1 <adriankvo22@gmail.com>

---------

Signed-off-by: AddRain1 <adriankvo22@gmail.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Issues / Pull Requests related to security kind/documentation Categorizes issue or PR as related to documentation. size/s

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Documentation] - Include audience field as part of Hashicorp Vault Kubernetes Auth

2 participants