fix: issue-5388: Fixes GCP Workload Identity Federation auth issue#5392
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom Oct 2, 2025
Merged
fix: issue-5388: Fixes GCP Workload Identity Federation auth issue#5392Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Bharath B <bhb@redhat.com>
Skarlso
reviewed
Oct 1, 2025
| } | ||
| config.SubjectTokenSupplier = &k8sSATokenReader{ | ||
| audience: config.Audience, | ||
| audience: w.config.Audience, |
Contributor
There was a problem hiding this comment.
Nice catch. I assume there were no tests for this? :D
Contributor
Author
There was a problem hiding this comment.
Yeah, the manual e2e tests would have caught, not sure when this typo happened :)
Skarlso
approved these changes
Oct 1, 2025
|
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…al-secrets#5392) Signed-off-by: Bharath B <bhb@redhat.com> Co-authored-by: Gergely Brautigam <skarlso777@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
GCP Workload Identity Federation authentication fails when
serviceAccountRefis specified.Related Issue
Fixes #5388
Proposed Changes
The issue is caused due to the incorrect initialization of the WIF audience.
Checklist
git commit --signoffmake testmake reviewable