fix(charts): exclude 'address' key from livenessProbe definition#5377
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom Sep 27, 2025
Merged
fix(charts): exclude 'address' key from livenessProbe definition#5377Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Baptiste Roux <arte.but.posix@gmail.com>
Skarlso
reviewed
Sep 26, 2025
| {{- if .Values.livenessProbe.enabled }} | ||
| livenessProbe: | ||
| {{- toYaml .Values.livenessProbe.spec | nindent 12 }} | ||
| {{- toYaml (omit .Values.livenessProbe.spec "address") | nindent 12 }} |
Contributor
There was a problem hiding this comment.
Damn it. If I would have known about "omit" I wouldn't have introduced spec :D :D Well, lesson learned here.
Skarlso
approved these changes
Sep 26, 2025
|
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…xternal-secrets#5377) Signed-off-by: Baptiste Roux <arte.but.posix@gmail.com> Co-authored-by: Gergely Brautigam <skarlso777@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
addressis not part of the allowed fields of the livenessProbe section (kubectl explain Pod.spec.containers.livenessProbe)Proposed Changes
We now exclude the
addressfield from the dict.Another option if you prefer would be to move the
addresskey one level above (.livenessProbeinstead of.livenessProbe.spec) so we can keep templating the full.livenessProbe.spec.Format
Checklist
git commit --signoffmake testmake reviewable