chore(lint): fix revive lint errors (pkg/providers)#5362
Merged
Skarlso merged 5 commits intoexternal-secrets:mainfrom Oct 3, 2025
Merged
chore(lint): fix revive lint errors (pkg/providers)#5362Skarlso merged 5 commits intoexternal-secrets:mainfrom
(pkg/providers)#5362Skarlso merged 5 commits intoexternal-secrets:mainfrom
Conversation
(pkg/providers)
85df1c0 to
f9d00c2
Compare
Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
…a Devops Secrets Management (DSM) provider (external-secrets#3895) * Initial Commit Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * Building an RSA-Based Sensitive Data Decryption Feature with Advanced Templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * docs: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * reviewable: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * docs: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * docs: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * chore(license): building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: remove bin data test on building an rsa-based sensitive data decryption feature Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: add encrypted data test on building an rsa-based sensitive data decryption feature Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: add encrypted data test on building an rsa-based sensitive data decryption feature Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> --------- Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
b4ef87a to
c0cd920
Compare
5 tasks
Signed-off-by: Gergely Brautigam <skarlso777@gmail.com>
Contributor
|
/ok-to-test sha=a21b179fbdcf1c8a1a54b400051969653e6467fb |
|
Skarlso
reviewed
Oct 3, 2025
Contributor
Skarlso
left a comment
There was a problem hiding this comment.
Excellent work! Thank you so much.
I'll run an e2e test just to see if everything is okay. :D
I went over it, don't see anything strange. :)
Contributor
Skarlso
approved these changes
Oct 3, 2025
Contributor
Author
|
I'll proceed with creating the remaining PRs. Thanks @Skarlso |
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…ts#5362) * chore(lint): fix revive lint errors in providers package Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> * feat: add support for decryption scheme from properties in senhasegura Devops Secrets Management (DSM) provider (external-secrets#3895) * Initial Commit Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * Building an RSA-Based Sensitive Data Decryption Feature with Advanced Templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * docs: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * reviewable: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * docs: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * docs: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * chore(license): building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: building an rsa-based sensitive data decryption feature with advanced templating v2 Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: remove bin data test on building an rsa-based sensitive data decryption feature Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: add encrypted data test on building an rsa-based sensitive data decryption feature Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> * test: add encrypted data test on building an rsa-based sensitive data decryption feature Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> --------- Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> * chore(lint): fix dot error Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> --------- Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> Signed-off-by: Felipe Oliveira dos Santos <felipeoliveira.s.br@gmail.com> Signed-off-by: Gergely Brautigam <skarlso777@gmail.com> Co-authored-by: Felipe Oliveira <felipeoliveira.s.br@gmail.com> Co-authored-by: Gergely Brautigam <skarlso777@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
According to this PR #3396 was implemented, the revive linter wasn't configured because it had loads of issues to be fixed. This PR configures the revive linter and fixes all the issues raised by the linter.
Related Issue
Fixes #3397
Proposed Changes
Fix all the issues raised by the linter so that we can configure the revive linter. It is the first in the series of PRs to follow.
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable