Skip to content

chore: update codeql action to also run for actions#5360

Merged
Skarlso merged 4 commits intoexternal-secrets:mainfrom
Skarlso:run-codeql-on-actions
Sep 24, 2025
Merged

chore: update codeql action to also run for actions#5360
Skarlso merged 4 commits intoexternal-secrets:mainfrom
Skarlso:run-codeql-on-actions

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Sep 24, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@github-actions github-actions bot added kind/chore Categorizes Pull Requests for chore activities (like bumping versions) component/github-actions size/s and removed kind/chore Categorizes Pull Requests for chore activities (like bumping versions) labels Sep 24, 2025
@Skarlso Skarlso mentioned this pull request Sep 24, 2025
Closed
@Skarlso
chore: update codeql action to also run for actions
d198927 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the run-codeql-on-actions branch from 85327fc to d198927 Compare September 24, 2025 05:19
@github-actions github-actions bot added the kind/chore Categorizes Pull Requests for chore activities (like bumping versions) label Sep 24, 2025
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Sep 24, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Sep 24, 2025

Nice, the run succeeded https://github.com/external-secrets/external-secrets/actions/runs/17967131953/job/51101771871?pr=5360

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Sep 24, 2025

Here is the list of checks executed by codeql: https://codeql.github.com/codeql-query-help/actions/

@Skarlso Skarlso moved this to In Review in External Secrets Sep 24, 2025
@Skarlso Skarlso requested a review from moolen September 24, 2025 08:18
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Sep 24, 2025

/lgtm

1 similar comment
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Sep 24, 2025

/lgtm

@eso-lgtm eso-lgtm bot added the lgtm label Sep 24, 2025
@eso-lgtm
Copy link
Copy Markdown

eso-lgtm bot commented Sep 24, 2025

✅ LGTM by @Skarlso (maintainer)

@Skarlso Skarlso removed the lgtm label Sep 24, 2025
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Sep 24, 2025

/lgtm

@eso-lgtm
Copy link
Copy Markdown

eso-lgtm bot commented Sep 24, 2025

✅ LGTM by @Skarlso (maintainer)

@eso-lgtm eso-lgtm bot added the lgtm label Sep 24, 2025
@github-actions github-actions bot removed the lgtm label Sep 24, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@webstradev
Copy link
Copy Markdown
Contributor

webstradev commented Sep 24, 2025

/lgtm

@eso-lgtm
Copy link
Copy Markdown

eso-lgtm bot commented Sep 24, 2025

@webstradev You must be a member of one of the required reviewer roles to use /lgtm.

Required roles for this PR: ci-reviewers

@Skarlso Skarlso requested a review from riccardomc September 24, 2025 15:37
@jakobmoellerdev
Copy link
Copy Markdown
Contributor

jakobmoellerdev commented Sep 24, 2025

/lgtm

@eso-lgtm eso-lgtm bot added the lgtm label Sep 24, 2025
@eso-lgtm
Copy link
Copy Markdown

eso-lgtm bot commented Sep 24, 2025

✅ LGTM by @jakobmoellerdev (maintainer)

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Sep 24, 2025

For now that's just a label. :D so it doesn't make the PR mergable. :)

@webstradev
Copy link
Copy Markdown
Contributor

webstradev commented Sep 24, 2025

For now that's just a label. :D so it doesn't make the PR mergable. :)

yeah most likely maintainers will not use lgtm much as they can just approve, but it's more aimed at reviewers for their respective tracks (supporting the new contributor ladder)

@jakobmoellerdev
Copy link
Copy Markdown
Contributor

jakobmoellerdev commented Sep 24, 2025

My 2 cents: I hate that we do not have /approve but have /lgtm, this is really inconsistent :D

@Skarlso Skarlso merged commit 0eaf966 into external-secrets:main Sep 24, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in External Secrets Sep 24, 2025
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
@Skarlso @SamuelMolling
chore: update codeql action to also run for actions (external-secrets…
9faabd1 
…#5360)

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

@moolen moolen Awaiting requested review from moolen

@riccardomc riccardomc Awaiting requested review from riccardomc

Assignees

No one assigned

Labels

component/github-actions kind/chore Categorizes Pull Requests for chore activities (like bumping versions) lgtm size/s

Projects

External Secrets
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skarlso @github-advanced-security @webstradev @jakobmoellerdev