feat(helm) Just use named port for webhook#5108
feat(helm) Just use named port for webhook#5108Skarlso merged 2 commits intoexternal-secrets:mainfrom jcpunk:webhook-port-name
Conversation
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
|
Errr. This will definitely break our chart. Especially if someone is using that configuration. :) |
|
I may be reading it wrongly but doesn't : ports:
- containerPort: {{ .Values.webhook.metrics.listen.port }}
protocol: TCP
name: metrics
- containerPort: {{ .Values.webhook.port }}
protocol: TCP
name: webhookfrom |
|
Ah you're right. This might be okay actually. |
|
It's just a bit confusing that it will be - targetPort: webhook (referring to the container's named port)
name: webhook (the service port's name)And I'm afraid if we rename it to something like webhook-svc we'll begin breaking things that reference it already. |
|
What if I convert the port name to another templated value from |
|
I'm wondering if this would be a problem for downstream users who rely on the port number being set to a number. That... wouldn't be a problem right? ( I'm not a helm/deployment power user ). If someone is parsing that by hand they would have their own problems anyways. :D Let's fix the helm test issue for now, other than that, this looks fine. |
I don't think that is something I can fix.... |
|
|
Looks like some kind of fluke. |
Problem Statement
Simplify inter-relationships in services/helm values
Related Issue
Fixes #...
Proposed Changes
Since the deployment already names the port, we can just use the name and it will map automatically.
Checklist
git commit --signoffmake testmake reviewable