deployment strategy support#5091
Conversation
|
Hello. Please accept the DCO before progressing. :) Thanks. |
|
@Skarlso The what? |
|
Sorry, I meant sign your commit. :) |
|
Yeah, I can't figure out how to do this. I have my gpg public added to my gh account. I tried I need some clearer instructions on how I can fix my branch. |
|
Also, the following steps:
Dont' work locally either. I get |
daadb7a to
62521df
Compare
|
I think I fixed the signoff issue |
|
I need someone assistance, as I can't figure out why the pipeline is failing. @Skarlso Can you help me with this? I see this in the error log: 15:51:57 [ .. ] checking that branch is clean I also notice 1 unit-test is failing, that one is my fault I think and will fix this. |
…ts#4984) * feat(aws): secretsmanager to update/patch/delete tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): secretsmanager to update/patch/delete tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): secretsmanager to update/patch/delete tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> --------- Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
…crets#5089) * fix: update the e2e test with the new store status value Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * add argo server side apply option Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * fix tab character instead of spaces 🤦 Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * add replace true for CRD updates Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * increase arcocd version and remove replace Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
…ernal-secrets#5092) * fix: correct usage of if in dlc and update for server side apply Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * fix tilt server side apply Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
Signed-off-by: Jeroen Jacobs <jeroen.jacobs@portofantwerpbruges.com>
15e68f0 to
3c47abe
Compare
|
Okay this is my final attempt. The readme is updated and the hem tests are fixed. I accidently forgot a signoff again, and followed the instructions about the rebase. |
|
Sorry, I was on vacation. Going to take a look tomorrow. |
|
|
Yes, well done. All you had to do was indeed run |
Problem Statement
Deployments in external-secrets helm chart does not support the
strategyfeatureRelated Issue
Fixes #...
Proposed Changes
This PR adds support for
strategyHow do you like to solve the issue and why?
Checklist
git commit --signoffmake testmake reviewable