hi! Can you fix the errors CI brought up? :)

Hey @gusfcarvalho , really sorry for the late reply.. I was able to return to it only now.
I made the necessary changes for the pipeline to pass (DCO+sonar).
I'll need approval to run the managed e2e tests? Or how do I proceed? Sorry, first time contributing to the project..

/ok-to-test sha=e87d38594076b36aaabaa37d6721fd05905ba11d

@xvirgov Ah looks like helm tests need a bit of adjusting. :)

[Bot] - ❌ e2e for e87d38594076b36aaabaa37d6721fd05905ba11d failed

@xvirgov Ah looks like helm tests need a bit of adjusting. :)

Hello @Skarlso , before I proceed, I'd like to know your opinion about the modifications. Which of the following options would be better?

1. Before "Run chart-testing (install)" build the images from the PR code and load them to the kind cluster, then use the development version of images in ct install command. What worries me about these changes is that I'm not completely sure about the flow of the testing since I'm new here, maybe it's desirable to do ct install of chart versions against the app version from main?
2. Leave in rbac for edpoints and clean it in another pr.

Thank you for the help :)

Oh I see since endpoints is forbidden. I would say leave it in for now especially for backwards compatibility, right?

Oh I see since endpoints is forbidden. I would say leave it in for now especially for backwards compatibility, right?

In the other operators they remove "endpoints" completely from rbac, see kube-prometheus and ext-dns. But I would agree to go with the easy way and keep it in for the sake of the tests. I'll make the change

Oh I see since endpoints is forbidden. I would say leave it in for now especially for backwards compatibility, right?

In the other operators they remove "endpoints" completely from rbac, see kube-prometheus and ext-dns. But I would agree to go with the easy way and keep it in for the sake of the tests. I'll make the change

Yah, you're right. And we should probably follow suite eventually, I agree. :) But as you said, we should go with the easier route for now and then leave this as a cleanup.

@Skarlso , I pulled from upstream the latest changes, so now the helm unittests should pass. Could you please retrigger?

/ok-to-test sha=496bef2f3469333ac5694a17707ce01dc9f79dae

Did you also merge my e2e test fix?

[Bot] - ✅ e2e for passed

Did you also merge my e2e test fix?

@Skarlso , this one? Yes, I rebased my branch from the latest changes that were in yesterday and this is few days old. I also checked the "make helm.test" to verify that the issue is fixed. Or do you mean something else?

Yah it's okay. The e2e test passed so it was running the latest test. :)

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud