fix(gitlab): restore group variable fallback to wildcard environment_scope and correct precedence#4965
Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom Jul 2, 2025
Conversation
Signed-off-by: Aakkash-Suresh <i-aakkash.s@devrev.ai>
16c6c84 to
8571868
Compare
Signed-off-by: Aakkash-Suresh <i-aakkash.s@devrev.ai>
Contributor
Author
|
@gusfcarvalho, would you mind taking a look at this PR when you have a moment? Thank you! |
Contributor
Author
|
@gusfcarvalho just a gentle reminder on this PR when you have a chance. |
Skarlso
approved these changes
Jul 2, 2025
Contributor
|
Thanks for the fix! |
|
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Jul 10, 2025
…scope and correct precedence (external-secrets#4965) * fix(gitlab): fallback to group wildcard variables and fix precedence Signed-off-by: Aakkash-Suresh <i-aakkash.s@devrev.ai> * refactor(gitlab): reduce cognitive complexity in fetchProjectVariables Signed-off-by: Aakkash-Suresh <i-aakkash.s@devrev.ai> --------- Signed-off-by: Aakkash-Suresh <i-aakkash.s@devrev.ai> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
Group-level GitLab variables with environment_scope = "*" (“All (default)”) are not being retrieved when a specific environment is set in the SecretStore. This causes expected secrets to be missing in common GitLab setups.
Related Issue
Fixes #4953
Proposed Changes
environment_scope = "*", matching the behavior for project variables.Checklist
git commit --signoffmake testmake reviewable