feat(provider/gitlab): Add support for custom CAs#4941
Merged
Skarlso merged 4 commits intoexternal-secrets:mainfrom Jun 27, 2025
Merged
feat(provider/gitlab): Add support for custom CAs#4941Skarlso merged 4 commits intoexternal-secrets:mainfrom
Skarlso merged 4 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: girishsr25 <sgirish585@gmail.com>
e20c81c to
47cb203
Compare
Contributor
Author
|
@Skarlso Please do review when you get time, thanks |
Contributor
|
Perfect. Looks fantastic. :) |
Skarlso
reviewed
Jun 26, 2025
Skarlso
reviewed
Jun 26, 2025
Signed-off-by: girishsr25 <sgirish585@gmail.com>
|
Skarlso
approved these changes
Jun 27, 2025
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Jul 10, 2025
) * lint: run make fmt and reviewable Signed-off-by: girishsr25 <sgirish585@gmail.com> * Update the docs Signed-off-by: girishsr25 <sgirish585@gmail.com> --------- Signed-off-by: girishsr25 <sgirish585@gmail.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
The GitLab provider cannot connect to self-hosted instances that use custom TLS certificates, causing certificate validation errors.
Related Issue
Fixes #4938
Proposed Changes
This PR adds support for custom Certificate Authorities (CAs) to the GitLab provider by introducing caBundle and caProvider fields. This allows users to provide a trusted CA certificate, enabling secure connections to their self-hosted GitLab. The implementation aligns with existing patterns in other providers.
Checklist
git commit --signoffmake testmake reviewable