[OnePasswordSDKProvider] Enable specifying the vault by UUID#4906
Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom Jun 16, 2025
Merged
Conversation
Signed-off-by: pollenjp <polleninjp@gmail.com>
Skarlso
approved these changes
Jun 15, 2025
Contributor
Skarlso
left a comment
There was a problem hiding this comment.
Should be okay after tests. Thanks for the addition. :)
Skarlso
requested changes
Jun 15, 2025
Contributor
Skarlso
left a comment
There was a problem hiding this comment.
Ah yes. Please run make check-diff and commit the diff that comes out. :) 🙇
Signed-off-by: pollenjp <polleninjp@gmail.com>
Contributor
Author
|
Thank you Skarlso! |
Contributor
|
@pollenjp No, thank you! :) We have a separate PR that I'll merge in a sec. :) |
|
Skarlso
approved these changes
Jun 16, 2025
Contributor
Author
|
Thank you!! |
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Jul 10, 2025
…l-secrets#4906) * [OnePasswordSDKProvider] Enable specifying the vault by UUID Signed-off-by: pollenjp <polleninjp@gmail.com> * run 'make reviewable' Signed-off-by: pollenjp <polleninjp@gmail.com> --------- Signed-off-by: pollenjp <polleninjp@gmail.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
SecretStore in onepasswordsdk only allows specifying a vault by its Title, and does not support specifying it by UUID.
For example, the following manifest will result in an error:
external-secrets/pkg/provider/onepasswordsdk/provider.go
Line 83 in cb0d91e
Related Issue
N/A (No issue created)
Proposed Changes
Checklist
git commit --signoffmake testmake reviewableThis is my first contribution to this project. I hope it's helpful. 🙇♂️