Fail helm install if ClusterPushSecrets processing is enabled but PushSecrets processing is disabled.#4896
Merged
gusfcarvalho merged 6 commits intoexternal-secrets:mainfrom Aug 5, 2025
Conversation
…hSecrets processing is disabled. Signed-off-by: Thomas D. Spear <thomas.spear@wcgclinical.com>
gusfcarvalho
approved these changes
Jun 14, 2025
|
Contributor
Author
|
Hi @gusfcarvalho I've pulled in the latest upstream to my branch. Is there anything else that's needed to get this merged? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Installations end up getting into a crashloop due to missing permissions for watching the namespace scoped PushSecrets resources where values are set as
processClusterPushSecret: true, butprocessPushSecret: false.Related Issue
Proposed Changes
Checklist
git commit --signoffmake testmake reviewable