Skip to content

feat(provider/infisical): azure auth and refactor to go sdk#4854

Merged
Skarlso merged 10 commits intoexternal-secrets:mainfrom
varonix0:daniel/infisical-azure-auth
Jun 29, 2025
Merged

feat(provider/infisical): azure auth and refactor to go sdk#4854
Skarlso merged 10 commits intoexternal-secrets:mainfrom
varonix0:daniel/infisical-azure-auth

Conversation

@varonix0
Copy link
Copy Markdown
Contributor

Problem Statement

Users are requesting to be able to use the Infisical provider with Azure Auth.

Proposed Changes

  • Moved to the Infisical Go SDK to avoid rewriting core logic.
  • Added azure auth for the provider.

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@varonix0 varonix0 requested a review from a team as a code owner May 29, 2025 20:14
@varonix0 varonix0 requested a review from moolen May 29, 2025 20:14
@Skarlso Skarlso self-requested a review June 4, 2025 14:35
@varonix0
Copy link
Copy Markdown
Contributor Author

varonix0 commented Jun 5, 2025

Removed local replace of our go SDK, tests should pass now!

@vmatsiiako
Copy link
Copy Markdown

Hi @Skarlso @moolen! Just wanted to follow up on this. Do you know when you might expect to merge this?

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 21, 2025

@vmatsiiako Hello. Just a note. Until tests are not all passing and issues are resolved maintainers usually don't start reviewing at all. :) So I suggest the PR author begins with solving the ci issues and the Sonar issue. :) Once those are done, we can start reviewing it.

@varonix0
Copy link
Copy Markdown
Contributor Author

Hi @Skarlso, the sonar issue has been resolved alongside the tests failing. PR should be ready for review!

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 26, 2025

@DanielHougaard Fantastic. Could you please sign your commits? :) Then we are good to go.

@varonix0
Copy link
Copy Markdown
Contributor Author

Hey @Skarlso, I fixed the failed lint test and signed my commits!

varonix0 added 9 commits June 27, 2025 21:58
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
Signed-off-by: Daniel Hougaard <daniel@infisical.com>
@varonix0
Copy link
Copy Markdown
Contributor Author

Hi @Skarlso, I've pushed the request changes. Could I please have you take another look?

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 28, 2025

Are old versions also working and it pushed the secret the same way? Or is this a breaking change?

@varonix0
Copy link
Copy Markdown
Contributor Author

varonix0 commented Jun 29, 2025

Are old versions also working and it pushed the secret the same way? Or is this a breaking change?

@Skarlso, older versions will continue to work the same way. This PR just moves the calls to use our official Go SDK, and it adds azure auth

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 29, 2025

Okay then

Copy link
Copy Markdown
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit 0c8bff8 into external-secrets:main Jun 29, 2025
3 checks passed
@varonix0
Copy link
Copy Markdown
Contributor Author

Thank you @Skarlso! When do you think we can get this released? We have quite a lot of folks waiting for this on our end

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 29, 2025

Hello. I'm not sure. We recently had a release. Maybe next week I'll create a 0.18.2. We don't really have a set cadence.

alliseeisgold pushed a commit to alliseeisgold/external-secrets that referenced this pull request Jul 10, 2025
…-secrets#4854)

Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants