Skip to content

fix: pdb spec rendering issue#4844

Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom
linusyong:fix/pdb-maxunavailable
Jun 4, 2025
Merged

fix: pdb spec rendering issue#4844
Skarlso merged 2 commits intoexternal-secrets:mainfrom
linusyong:fix/pdb-maxunavailable

Conversation

@linusyong
Copy link
Copy Markdown
Contributor

@linusyong linusyong commented May 26, 2025 •
edited
Loading

Problem Statement

When specifying only maxUnavailable for podDisruptionBudget, the PodDisruptionBudget manifest is generated with both spec.minAvailable and spec.maxUnavailable which is invalid.

Related Issue

Fixes #4832

Proposed Changes

Ensure that if podDisruptionBudget.maxUnavailable is specified, spec.minAvailable is not render with

{{- if ... ... ... }}
{{- else if ... ... ... }}
{{- end }}

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@linusyong linusyong marked this pull request as ready for review May 27, 2025 01:13
@linusyong linusyong requested a review from a team as a code owner May 27, 2025 01:13
@linusyong linusyong requested a review from knelasevero May 27, 2025 01:13
@linusyong
fix: pdb spec rendering issue
1fc1903 
Fixes: external-secrets#4832
Signed-off-by: Linus Yong <linusyong@gmail.com>
@linusyong linusyong force-pushed the fix/pdb-maxunavailable branch from be34c38 to 1fc1903 Compare May 28, 2025 00:31
Skarlso
Skarlso previously approved these changes Jun 2, 2025
View reviewed changes
@Skarlso Skarlso dismissed their stale review June 2, 2025 05:05

too early

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 2, 2025

@linusyong Thanks for the fix. Could you please add a helm test for this scenario? Thank you :bow

@gusfcarvalho
Copy link
Copy Markdown
Member

gusfcarvalho commented Jun 3, 2025

@Skarlso this aligns very well with the default values changes 😄 so all of them packed in a 0.18 looks nice for me 👯

@Skarlso Skarlso merged commit a094481 into external-secrets:main Jun 4, 2025
2 checks passed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pepordev pushed a commit to pepordev/external-secrets that referenced this pull request Jun 11, 2025
@linusyong @Skarlso @pepordev
fix: pdb spec rendering issue (external-secrets#4844)
ad3e446 
Fixes: external-secrets#4832

Signed-off-by: Linus Yong <linusyong@gmail.com>
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
alliseeisgold pushed a commit to alliseeisgold/external-secrets that referenced this pull request Jul 10, 2025
@linusyong @Skarlso
fix: pdb spec rendering issue (external-secrets#4844)
0eb09d8 
Fixes: external-secrets#4832

Signed-off-by: Linus Yong <linusyong@gmail.com>
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

@knelasevero knelasevero Awaiting requested review from knelasevero knelasevero was automatically assigned from external-secrets/maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PodDisruptionBudget helm template bug with maxUnavailable

3 participants

@linusyong @Skarlso @gusfcarvalho