Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Skarlso
approved these changes
May 27, 2025
Skarlso
approved these changes
May 27, 2025
|
Member
Author
|
this might have broken e2e tests 😄 - I'll double check and try to fix them. |
pepordev
pushed a commit
to pepordev/external-secrets
that referenced
this pull request
Jun 11, 2025
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Generator States are not generated when using them to
PushSecrets. This is caused because we are checking if a state exists before creating a new one, but that clearly is never the case (as no state exists on the very first run)Related Issue
Fixes #4830
Proposed Changes
Make the logic more like
ExternalSecrets one.Checklist
git commit --signoffmake testmake reviewable