feat(aws): Enable setting custom endpoints for AWS ECR for ECRAuthori…#4821
Conversation
|
I noticed on another PR around auth type stuff that this will probably not be accepted due to the aws-go-sdk-v2 upgrade (#4484). With the upgrade to v2, will the standard AWS_ENDPOINT_URL_* environment variables be supported by default? |
|
hi @mtweten ! it's not that it isn't going to be accepted; but we'd like to merge this one after sdk v2 work is finished 😄. Alternatively, if you can sync and add this contribution to both SDKs (v1 being this one, and another contribution in v2), I see no problem in adding this PR right away. We just don't want to cause more changes for the volunteers that are pushing sdk v2. |
|
@gusfcarvalho Thanks for the response! I'm not certain, but I think the v2 upgrade will make it so external-secrets won't need to explicitly provide support for endpoint overrides - I think with v2 AWS_ENDPOINT_URL_* environment variables are supported by default. I noticed in the v2 PR that both of the existing environment variable overrides, Either way, I'm fine with holding off on this! |
|
I believe that #4484 is a breaking change since it removed both of the environment variables currently supported to set custom endpoints for the SSM and Secrets Manager services (AWS_SECRETSMANAGER_ENDPOINT and AWS_SSM_ENDPOINT): https://github.com/external-secrets/external-secrets/pull/4484/files#diff-9c6c21b0dfd29225505dd5e59527cc6e2a1cff3bd32c61aa16062df2e6222ae6L24 |
|
@mtweten isn't it still there in the resolver? https://github.com/external-secrets/external-secrets/pull/4484/files#diff-2cc22752e0b4a69ae5c590a1225325f4f2e17fd34b8bf7223b3a511d1e894779 |
|
@Skarlso My bad! I didn't see that they got moved. Thanks for pointing that out |
…zationToken generator Signed-off-by: Michael Tweten <mtweten@gmail.com>
b3132b0 to
e2ba13a
Compare
|
|
I've updated this PR to use the same pattern for resolving custom endpoints that was used in the aws-go-sdk-v2 update and verified that it works correctly for overriding ECR endpoints. |
…zationToken generator (external-secrets#4821) Signed-off-by: Michael Tweten <mtweten@gmail.com> Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
…zationToken generator
Problem Statement
The external-secrets AWS provider currently allows setting custom endpoints for the STS, SSM, and SecretsManager services. However, the ECRAuthorizationToken generator does not currently support custom endpoints for the ECR/ECR Public services.
Related Issue
No corresponding issue.
Proposed Changes
Expose environment variables for ECR and ECR public services similar to the existing custom endpoint overrides.
Checklist
git commit --signoffmake testmake reviewable