fix: gcp regional push should have no replications#4815
Merged
gusfcarvalho merged 3 commits intomainfrom May 27, 2025
Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Skarlso
approved these changes
May 21, 2025
|
pepordev
pushed a commit
to pepordev/external-secrets
that referenced
this pull request
Jun 11, 2025
…4815) Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com> Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
GCP Regional Push Secrets should contain no Replication
Related Issue
Fixes #4812
Proposed Changes
Add a check before setting replication
Checklist
git commit --signoffmake testmake reviewable