Skip to content

fix: allows result.jsonpath to be templated on datafrom calls#4808

Merged
Skarlso merged 2 commits intomainfrom
gc/fix/webhook-datafrom-provider-map
May 20, 2025
Merged

fix: allows result.jsonpath to be templated on datafrom calls#4808
Skarlso merged 2 commits intomainfrom
gc/fix/webhook-datafrom-provider-map

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Member

Problem Statement

Webhook provider does not allow result.JsonPath to be templated when calls come from dataFrom - even though it is stated in the docs it should be possible.

This PR fixes this by, well, templating the jsonPath :)

Related Issue

Fixes #4801

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
@gusfcarvalho gusfcarvalho requested a review from a team as a code owner May 20, 2025 10:20
@gusfcarvalho gusfcarvalho requested a review from Skarlso May 20, 2025 10:20
@Skarlso Skarlso merged commit c27fb96 into main May 20, 2025
7 checks passed
@Skarlso Skarlso deleted the gc/fix/webhook-datafrom-provider-map branch May 20, 2025 12:23
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using "dataFrom" webhook "ClusterSecretStore"'s templated "result.jsonPath" does not work

2 participants