fix: generator state controller trying to delete twice#4806
Merged
gusfcarvalho merged 2 commits intoexternal-secrets:mainfrom May 21, 2025
Merged
Conversation
Signed-off-by: msfernandes <matheus.souza.fernandes@gmail.com>
Skarlso
approved these changes
May 20, 2025
Contributor
Author
|
@moolen Could you take a look at this one, please? |
|
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
When the GeneratorState is deleted it triggers the reconciler again and since all requirements needed to delete the object is satisfied, it tries to delete again, causing the error
could not delete GeneratorState. To avoid this, I just added a check before the deletion, verifying if the resource was already marked for deletion.Checklist
git commit --signoffmake testmake reviewable