Skip to content

docs: Fix formatting in Deprecation Policy notes#4791

Merged
gusfcarvalho merged 2 commits intoexternal-secrets:mainfrom
kingdonb:fix-deprecation-formatting
May 18, 2025
Merged

docs: Fix formatting in Deprecation Policy notes#4791
gusfcarvalho merged 2 commits intoexternal-secrets:mainfrom
kingdonb:fix-deprecation-formatting

Conversation

@kingdonb
Copy link
Copy Markdown
Contributor

@kingdonb kingdonb commented May 18, 2025

There's a formatting error in the very fine Deprecation Policy guide:

Screenshot 2025-05-18 at 9 31 17 AM

Thanks for the level of detail in here! I don't know of any better place where Kubernetes Versioning is concisely explained. 🚀

Good luck with your 1.0.0 release!

@kingdonb
docs: Fix formatting in Deprecation Policy notes
c938658 
Signed-off-by: Kingdon B <kingdon@urmanac.com>
@kingdonb kingdonb requested a review from a team as a code owner May 18, 2025 13:32
@kingdonb kingdonb requested a review from Skarlso May 18, 2025 13:32
@kingdonb
Copy link
Copy Markdown
Contributor Author

kingdonb commented May 18, 2025 •
edited
Loading

Hey, I just noticed this might not be the source for the website, because there was another typo in the screenshot (insn't) and I didn't find that anywhere in the source history of this file. Sorry for the noise.

@gusfcarvalho
Copy link
Copy Markdown
Member

gusfcarvalho commented May 18, 2025 •
edited
Loading

hi @kingdonb ! This is the file you want to edit! https://github.com/external-secrets/external-secrets/blob/main/docs/introduction/deprecation-policy.md. Thanks for contributing to our docs!!

Good luck with your 1.0.0 release!

Thanks! I hope it goes better than this current release 😆 😅 😰 🥵

@kingdonb
docs: Fix grammar and formatting errors, spelling
0746037 
Signed-off-by: Kingdon B <kingdon@urmanac.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gusfcarvalho gusfcarvalho merged commit 137e446 into external-secrets:main May 18, 2025
12 checks passed
@kingdonb
Copy link
Copy Markdown
Contributor Author

kingdonb commented May 18, 2025

Thanks! I hope it goes better than this current release

Ah yes, well, it has to go much better now! Obviously, since all that stuff's out of the way 😅🗑️🔥

@kingdonb kingdonb deleted the fix-deprecation-formatting branch May 18, 2025 22:52
@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented May 19, 2025

Oh hai Kingdon. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gusfcarvalho gusfcarvalho gusfcarvalho approved these changes

@Skarlso Skarlso Awaiting requested review from Skarlso Skarlso was automatically assigned from external-secrets/maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kingdonb @gusfcarvalho @Skarlso