Skip to content

feat: add MFA token generator Generator#4790

Merged
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:add-mfa-generator
May 20, 2025
Merged

feat: add MFA token generator Generator#4790
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:add-mfa-generator

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented May 17, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso requested a review from a team as a code owner May 17, 2025 13:32
Skarlso added 2 commits May 18, 2025 07:59
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented May 18, 2025

Working setup with AWS MFA ( don't worry, I deleted the entire account so no security compromised. :P ):

Screenshot 2025-05-18 at 7 49 28 Screenshot 2025-05-18 at 11 07 14 Screenshot 2025-05-18 at 11 07 18 Screenshot 2025-05-18 at 11 07 46

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso merged commit e5fac24 into external-secrets:main May 20, 2025
10 checks passed
@Skarlso Skarlso deleted the add-mfa-generator branch May 20, 2025 14:48
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants