Update docs/example for ECR token generator#4773
Merged
Skarlso merged 4 commits intoexternal-secrets:mainfrom May 14, 2025
Merged
Update docs/example for ECR token generator#4773Skarlso merged 4 commits intoexternal-secrets:mainfrom
Skarlso merged 4 commits intoexternal-secrets:mainfrom
Conversation
With this templating, it will generate an actually usable secret that is of type dockerconfig and in the proper expected format Signed-off-by: Moulick Aggarwal <15780903+Moulick@users.noreply.github.com>
gusfcarvalho
approved these changes
May 13, 2025
Contributor
Author
|
@gusfcarvalho Can you please approve running the workflows as well? |
Member
|
@Moulick sure! but our workflows do not do docs checks, so this will likely skip most of the checks |
Skarlso
approved these changes
May 14, 2025
|
1 task
1 task
1 task
This was referenced Aug 3, 2025
This was referenced Aug 3, 2025
1 task
This was referenced Aug 4, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this templating, it will generate an actually usable secret that is of type dockerconfig and in the proper expected format
Problem Statement
The example for ECR token generator is incomplete. The current example creates a secret that is unusable as
imagePullSecretsRelated Issue
Fixes #... None
Proposed Changes
Update the docs/example to make it easier for people to copy paste
Checklist
git commit --signoff