fix: Show Errors from Github#4753
Merged
Skarlso merged 4 commits intoexternal-secrets:mainfrom May 8, 2025
Merged
Conversation
Signed-off-by: Alexander Cairns <alexandercairns@discoverygarden.ca>
Skarlso
reviewed
May 8, 2025
Signed-off-by: Alexander Cairns <alexandercairns@discoverygarden.ca>
1e0a2f7 to
ee97ec5
Compare
Skarlso
approved these changes
May 8, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
The Github generator does not return Github api errors when it fails to generate a token.
Related Issue
No linked issue
Proposed Changes
Adds a check on the status code and returns an error with the Github error.
Checklist
git commit --signoffmake test(Some tests were failing before I made any changes, the same tests are failing after my changes)make reviewable