Skip to content

fix: add kmskeyid to secret creation#4729

Merged
Skarlso merged 1 commit intomainfrom
fix-kms-not-passed-in
May 2, 2025
Merged

fix: add kmskeyid to secret creation#4729
Skarlso merged 1 commit intomainfrom
fix-kms-not-passed-in

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented May 2, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #1817 (comment)

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso requested a review from a team as a code owner May 2, 2025 11:39
@Skarlso Skarlso requested a review from moolen May 2, 2025 11:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 2, 2025

@Skarlso Skarlso merged commit 3fce06d into main May 2, 2025
20 checks passed
@Skarlso Skarlso deleted the fix-kms-not-passed-in branch May 2, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PushSecret to AWS Secrets Manager: Define KMS key to use to encrypt secret

2 participants