fix: ClusterExternalSecrets were not able to adopt externalSecret after update to v1#4724
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom May 2, 2025
Meallia:fix-v1beta1-to-v1-externalsecrets-ownerref
Merged
fix: ClusterExternalSecrets were not able to adopt externalSecret after update to v1#4724Skarlso merged 2 commits intoexternal-secrets:mainfrom Meallia:fix-v1beta1-to-v1-externalsecrets-ownerref
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Meallia:fix-v1beta1-to-v1-externalsecrets-ownerref
Conversation
…ter update to v1 Signed-off-by: Jonathan GAYVALLET <jonathan.gayvallet@orange.com>
Contributor
|
/ok-to-test sha=3cba0e8de648ae25b2faed9949c231ee03559aea |
Contributor
Skarlso
approved these changes
May 2, 2025
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
When checking if an ExternalSecret is owned by a ClusterExternalSecret, the full apiversion is used. When migrating from v1beta1 to v1, the controller behave as is the ExternalSecret is no longer owned and won't update it.
Related Issue
Fixes #4708
Proposed Changes
Instead of comparing the
apiVersionfield of the owner, we useGroupKindlike it's done in theExternalSecrets's controller.Checklist
git commit --signoffmake testmake reviewable