Update md5 hashing algorithim to sha3#4696
Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom Apr 23, 2025
Merged
Conversation
Signed-off-by: Kyle Steere <kyle.steere@chainguard.dev>
|
Member
|
/ok-to-test sha=c7217b0 |
Contributor
|
[Bot] - ❌ e2e for c7217b0 failed |
Member
|
/ok-to-test sha=c7217b095c95080f1e1fc7ca5f5aa77f531a29e3 |
Contributor
|
This will break existing hashes of course. |
Member
Yeah, i guess that should be fine. I just ran a test and it updates the hashes on controller startup |
Contributor
Skarlso
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
MD5 is an outdated algorithm that is no longer considered secure due to its vulnerabilities, which can compromise the reliability of data verification. This is specifically relevant in terms of NIST requirements for FIPS but also the industry at large has been moving away from MD5 for years.
Proposed Changes
Switching the hashing algorithm to SHA3 provides a modern algorithm that meets current and future industry requirements.
Checklist
git commit --signoffmake testmake reviewable