I'm not against this per-say, however, this would mean that now, if we ship it, we maintain it. And I, personally, don't want to keep a grafana dashboard maintained. :D So I'm on the fence. :) @gusfcarvalho what are your thoughts?

While I am not a maintainer here, for the foreseeable future I can help maintain the dashboard and this feature. It should be pretty low maintenance especially given a 1.0 release appears to be incoming?

Edit: I swore I saw a 1.0.0-rc tag a few days ago 😆

@onedr0p I appreciate that, however, I'm thinking more long term. :) Will you be available in 1-2 years too? :D

I can't predict the future but I have been using ESO for the past 3+ years at the workplace and homelab, and cannot see myself migrating away any time soon or quitting the industry and starting a Llama farm.

Okay then. I have no concerns with adding one. Can you paste in a screenshot of the dashboard by any chance please? :) 🙇

Sure, it's the same one provided in the docs here, probably could use some updating but maybe that can be tackled in another PR.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

🥲 I am a bit concerned with our ability to provide support for users that don’t have a clue on whats going on. But maybe this helps issues like #4615

Also, would this render with flux/argocd? 🧐

I don't see why this wouldn't render with those? I'm using other charts with Flux that implement this just fine. I can't speak to Argo though

Iirc Argocd does not implement the full feature set for helm templating. Iirc things like lookup for sure does not work, so I was wondering if get file would, as I think (IIRC) we don’t ship the dashboard within our helm chart package

I know some of the nuances with Argo and Helm, and honestly it's not something that should hold back chart developers to implement features. If there are easy enough workarounds sure, then it makes sense to implement but anything hacky I'd argue Argo folks can workaround the issue themselves.

I know some of the nuances with Argo and Helm, and honestly it's not something that should hold back chart developers to implement features. If there are easy enough workarounds sure, then it makes sense to implement but anything hacky I'd argue Argo folks can workaround the issue themselves.

if only that were really true… 🥹

related to this PR: I believe we missed adding the JSON file to our helm packages. I’m almost 100% sure if users did helm install external-secrets external-secrets/external-secrets —set… that will fail because there’s no file path available for helm to find and consume

related to this PR: I believe we missed adding the JSON file to our helm packages. I’m almost 100% sure if users did helm install external-secrets external-secrets/external-secrets —set… that will fail because there’s no file path available for helm to find and consume

Can you explain a bit further? I based this PR off of work done in the Cilium and CNPG helm charts and those don't have that issue. I don't see any reason why it's not packaged, there's nothing in the .helmignore telling it to ignore the JSON file.

Take a look on our latest helm release (unpack the .tgz)

My belief here is that there will be no json file for helm to render, which either will generate no dashboards or throw a helm error.

something to look at when we release 😁

Nvm me I completely missed the file addition there. All good!!