feat: add 1Password SDK based provider#4628
Conversation
61bd145 to
baa7571
Compare
baa7571 to
859a18e
Compare
|
@gusfcarvalho should this wait for v1 promotion? 🤔 |
|
I mean, I think so! v1 promotion is literally ready to go (aside from reviews of course) |
|
Okay, I'll review that one today. |
apis/externalsecrets/v1beta1/secretstore_onepassword_sdk_types.go
Outdated
Show resolved
Hide resolved
859a18e to
607e135
Compare
ef11747 to
92faca3
Compare
a72725d to
2a7a536
Compare
|
Since this is in v1, it will have all available features when done. I already added pushsecret. Now, only DeleteSecret and GetAllSecrets is left. All those is supported by the SDK. In terms of HOW, it will mirror whatever people had to do with the connector one, with a slight modification that Getting a secret uses the Secret Reference method instead which is a lot simpler. |
bdbfdac to
90e0f74
Compare
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
…unit tests Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
feb8937 to
a07b728
Compare
|
@gusfcarvalho Looking forward to this being reviewed :) |
|
This will likely come with the 0.17.0 release that we are planning. :) |
|
Did a first batch of comments 😄 looking good thus far 💪 |
|
Thanks Gustavo!! |
Co-authored-by: Gustavo Fernandes de Carvalho <17139678+gusfcarvalho@users.noreply.github.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gustavo Fernandes de Carvalho <17139678+gusfcarvalho@users.noreply.github.com>
|





Problem Statement
1Password using the SDK
TODOs
Related Issue
Fixes #3655
Proposed Changes
How do you like to solve the issue and why?
Checklist
git commit --signoffmake testmake reviewable