Add values.schema.json generation to Helm chart#3774
Merged
Skarlso merged 14 commits intoexternal-secrets:mainfrom Aug 30, 2024
Merged
Add values.schema.json generation to Helm chart#3774Skarlso merged 14 commits intoexternal-secrets:mainfrom
Skarlso merged 14 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
gusfcarvalho
reviewed
Aug 7, 2024
.github/workflows/helm.yml
Outdated
Comment on lines
+37
to
+44
| - name: Install Helm Schema Plugin | ||
| run: | | ||
| helm plugin install https://github.com/losisin/helm-values-schema-json.git | ||
|
|
||
| - name: Generate values.schema.json | ||
| run: | | ||
| helm schema -input deploy/charts/external-secrets/values.yaml -output deploy/charts/external-secrets/values.schema.json | ||
|
|
Member
There was a problem hiding this comment.
Adding this to here means we will never be sure that the latest version of values.schema.json is commited, as this is produced on CI time only.
Instead, can we add the generation as a make command (e.g. make helm.schema.update) and run it on make check-diff ? This will enforce to update the schema for any updates to helm charts that changes it - on PR time.
Member
|
Hi @PrateekKumar1709 ! Thanks for your contribution! 🙇 I believe this would better fit if added as part of our |
Contributor
Author
Totally agreed. Thank for your feedback and pointing this out @gusfcarvalho |
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
…grate with check-diff Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
87125b5 to
96ba2f3
Compare
Member
|
Hi @PrateekKumar1709 sorry to bother - can you also run |
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
Contributor
Author
|
@gusfcarvalho Can you please review the PR again and let me know if everything looks good to you? Thanks. |
Contributor
Author
|
@gusfcarvalho can I get a review on this please? Thanks |
Skarlso
reviewed
Aug 20, 2024
| required: | ||
| - vaultUrl | ||
| type: object | ||
| beyondtrust: |
Contributor
There was a problem hiding this comment.
This should disappear once you merge latest.
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
Contributor
Author
|
@Skarlso Requesting you to review this. Thank you. |
Skarlso
reviewed
Aug 26, 2024
Contributor
Skarlso
left a comment
There was a problem hiding this comment.
Nice, looking good. Just one ask, than this is done. :)
Makefile
Outdated
| @cd e2e/ && go mod tidy | ||
|
|
||
| check-diff: reviewable ## Ensure branch is clean. | ||
| check-diff: reviewable helm.schema.update ## Ensure branch is clean. |
Contributor
There was a problem hiding this comment.
Put this after helm.generate in reviewable` target instead please. :)
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
|
Contributor
Author
|
Can this be merged now @Skarlso? |
Skarlso
approved these changes
Aug 30, 2024
Contributor
|
Yes, thanks! |
dc-tec
referenced
this pull request
in dc-tec/k8s-gitops
Sep 12, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [external-secrets](https://redirect.github.com/external-secrets/external-secrets) | HelmChart | patch | `0.10.2` -> `0.10.3` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.10.3`](https://redirect.github.com/external-secrets/external-secrets/releases/tag/v0.10.3) [Compare Source](https://redirect.github.com/external-secrets/external-secrets/compare/v0.10.2...v0.10.3) Image: `ghcr.io/external-secrets/external-secrets:v0.10.3` Image: `ghcr.io/external-secrets/external-secrets:v0.10.3-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.10.3-ubi-boringssl` #### What's Changed - release: update helm charts to version v0.10.2 by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3846](https://redirect.github.com/external-secrets/external-secrets/pull/3846) - Use Conjur API's built in JWT functions by [@​szh](https://redirect.github.com/szh) in [https://github.com/external-secrets/external-secrets/pull/3771](https://redirect.github.com/external-secrets/external-secrets/pull/3771) - fix: set grpc resolver explicitly in yandex by [@​stek29](https://redirect.github.com/stek29) in [https://github.com/external-secrets/external-secrets/pull/3838](https://redirect.github.com/external-secrets/external-secrets/pull/3838) - Add values.schema.json generation to Helm chart by [@​PrateekKumar1709](https://redirect.github.com/PrateekKumar1709) in [https://github.com/external-secrets/external-secrets/pull/3774](https://redirect.github.com/external-secrets/external-secrets/pull/3774) - fix: only replace data if it is in the middle of the path by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3852](https://redirect.github.com/external-secrets/external-secrets/pull/3852) - fix: bitwarden API url to point to the correct default location by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3848](https://redirect.github.com/external-secrets/external-secrets/pull/3848) - feat: update bitwarden server sdk chart version by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3850](https://redirect.github.com/external-secrets/external-secrets/pull/3850) - chore(deps): bump github/codeql-action from 3.26.5 to 3.26.6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3855](https://redirect.github.com/external-secrets/external-secrets/pull/3855) - chore(deps): bump actions/setup-python from 5.1.1 to 5.2.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3856](https://redirect.github.com/external-secrets/external-secrets/pull/3856) - chore(deps): bump mkdocs-material from 9.5.33 to 9.5.34 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3857](https://redirect.github.com/external-secrets/external-secrets/pull/3857) - chore(deps): bump mkdocs from 1.6.0 to 1.6.1 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3858](https://redirect.github.com/external-secrets/external-secrets/pull/3858) - chore(deps): bump watchdog from 4.0.2 to 5.0.0 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3861](https://redirect.github.com/external-secrets/external-secrets/pull/3861) - chore(deps): bump certifi from 2024.7.4 to 2024.8.30 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3859](https://redirect.github.com/external-secrets/external-secrets/pull/3859) - chore(deps): bump zipp from 3.20.0 to 3.20.1 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3860](https://redirect.github.com/external-secrets/external-secrets/pull/3860) - chore: update dependencies by [@​eso-service-account-app](https://redirect.github.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3862](https://redirect.github.com/external-secrets/external-secrets/pull/3862) - Add blog post about ESO and IBM Secrets Manager by [@​sali2801](https://redirect.github.com/sali2801) in [https://github.com/external-secrets/external-secrets/pull/3867](https://redirect.github.com/external-secrets/external-secrets/pull/3867) - Removed duplicate and deprecated API spec page by [@​7Pawns](https://redirect.github.com/7Pawns) in [https://github.com/external-secrets/external-secrets/pull/3868](https://redirect.github.com/external-secrets/external-secrets/pull/3868) - Delinea provider is listed twice on the documentation page, and Delin… by [@​oscerd](https://redirect.github.com/oscerd) in [https://github.com/external-secrets/external-secrets/pull/3874](https://redirect.github.com/external-secrets/external-secrets/pull/3874) - Updated supported versions table for 0.10 release by [@​shazib-summar](https://redirect.github.com/shazib-summar) in [https://github.com/external-secrets/external-secrets/pull/3873](https://redirect.github.com/external-secrets/external-secrets/pull/3873) - feat: adds scarf to docs by [@​gusfcarvalho](https://redirect.github.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3876](https://redirect.github.com/external-secrets/external-secrets/pull/3876) - docs: Update sponsors by [@​gusfcarvalho](https://redirect.github.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3877](https://redirect.github.com/external-secrets/external-secrets/pull/3877) - chore: add eso tools page by [@​Sn0rt](https://redirect.github.com/Sn0rt) in [https://github.com/external-secrets/external-secrets/pull/3870](https://redirect.github.com/external-secrets/external-secrets/pull/3870) - New Generator for UUIDs by [@​aschaber1](https://redirect.github.com/aschaber1) in [https://github.com/external-secrets/external-secrets/pull/3296](https://redirect.github.com/external-secrets/external-secrets/pull/3296) - fix: update uuids.generator shortname by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3883](https://redirect.github.com/external-secrets/external-secrets/pull/3883) - chore(deps): bump alpine from `0a4eaa0` to `beefdbd` in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3884](https://redirect.github.com/external-secrets/external-secrets/pull/3884) - chore(deps): bump alpine from `0a4eaa0` to `beefdbd` by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3886](https://redirect.github.com/external-secrets/external-secrets/pull/3886) - chore(deps): bump distroless/static from `ce46866` to `95eb83a` by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3887](https://redirect.github.com/external-secrets/external-secrets/pull/3887) - chore(deps): bump golang from 1.23.0 to 1.23.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3888](https://redirect.github.com/external-secrets/external-secrets/pull/3888) - chore(deps): bump golang from 1.23.0-bookworm to 1.23.1-bookworm in /e2e by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3889](https://redirect.github.com/external-secrets/external-secrets/pull/3889) - chore(deps): bump alpine from 3.20.2 to 3.20.3 in /e2e by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3890](https://redirect.github.com/external-secrets/external-secrets/pull/3890) - chore(deps): bump watchdog from 5.0.0 to 5.0.2 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3891](https://redirect.github.com/external-secrets/external-secrets/pull/3891) - chore(deps): bump platformdirs from 4.2.2 to 4.3.2 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3892](https://redirect.github.com/external-secrets/external-secrets/pull/3892) - chore: update dependencies by [@​eso-service-account-app](https://redirect.github.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3893](https://redirect.github.com/external-secrets/external-secrets/pull/3893) #### New Contributors - [@​stek29](https://redirect.github.com/stek29) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3838](https://redirect.github.com/external-secrets/external-secrets/pull/3838) - [@​sali2801](https://redirect.github.com/sali2801) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3867](https://redirect.github.com/external-secrets/external-secrets/pull/3867) - [@​7Pawns](https://redirect.github.com/7Pawns) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3868](https://redirect.github.com/external-secrets/external-secrets/pull/3868) - [@​oscerd](https://redirect.github.com/oscerd) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3874](https://redirect.github.com/external-secrets/external-secrets/pull/3874) - [@​Sn0rt](https://redirect.github.com/Sn0rt) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3870](https://redirect.github.com/external-secrets/external-secrets/pull/3870) **Full Changelog**: external-secrets/external-secrets@v0.10.2...v0.10.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Ni4xIiwidXBkYXRlZEluVmVyIjoiMzguNzYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=--> Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Sep 19, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://redirect.github.com/external-secrets/external-secrets) | patch | `0.10.2` -> `0.10.3` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.10.3`](https://redirect.github.com/external-secrets/external-secrets/releases/tag/v0.10.3) [Compare Source](https://redirect.github.com/external-secrets/external-secrets/compare/v0.10.2...v0.10.3) Image: `ghcr.io/external-secrets/external-secrets:v0.10.3` Image: `ghcr.io/external-secrets/external-secrets:v0.10.3-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.10.3-ubi-boringssl` #### What's Changed - release: update helm charts to version v0.10.2 by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3846](https://redirect.github.com/external-secrets/external-secrets/pull/3846) - Use Conjur API's built in JWT functions by [@​szh](https://redirect.github.com/szh) in [https://github.com/external-secrets/external-secrets/pull/3771](https://redirect.github.com/external-secrets/external-secrets/pull/3771) - fix: set grpc resolver explicitly in yandex by [@​stek29](https://redirect.github.com/stek29) in [https://github.com/external-secrets/external-secrets/pull/3838](https://redirect.github.com/external-secrets/external-secrets/pull/3838) - Add values.schema.json generation to Helm chart by [@​PrateekKumar1709](https://redirect.github.com/PrateekKumar1709) in [https://github.com/external-secrets/external-secrets/pull/3774](https://redirect.github.com/external-secrets/external-secrets/pull/3774) - fix: only replace data if it is in the middle of the path by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3852](https://redirect.github.com/external-secrets/external-secrets/pull/3852) - fix: bitwarden API url to point to the correct default location by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3848](https://redirect.github.com/external-secrets/external-secrets/pull/3848) - feat: update bitwarden server sdk chart version by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3850](https://redirect.github.com/external-secrets/external-secrets/pull/3850) - chore(deps): bump github/codeql-action from 3.26.5 to 3.26.6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3855](https://redirect.github.com/external-secrets/external-secrets/pull/3855) - chore(deps): bump actions/setup-python from 5.1.1 to 5.2.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3856](https://redirect.github.com/external-secrets/external-secrets/pull/3856) - chore(deps): bump mkdocs-material from 9.5.33 to 9.5.34 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3857](https://redirect.github.com/external-secrets/external-secrets/pull/3857) - chore(deps): bump mkdocs from 1.6.0 to 1.6.1 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3858](https://redirect.github.com/external-secrets/external-secrets/pull/3858) - chore(deps): bump watchdog from 4.0.2 to 5.0.0 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3861](https://redirect.github.com/external-secrets/external-secrets/pull/3861) - chore(deps): bump certifi from 2024.7.4 to 2024.8.30 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3859](https://redirect.github.com/external-secrets/external-secrets/pull/3859) - chore(deps): bump zipp from 3.20.0 to 3.20.1 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3860](https://redirect.github.com/external-secrets/external-secrets/pull/3860) - chore: update dependencies by [@​eso-service-account-app](https://redirect.github.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3862](https://redirect.github.com/external-secrets/external-secrets/pull/3862) - Add blog post about ESO and IBM Secrets Manager by [@​sali2801](https://redirect.github.com/sali2801) in [https://github.com/external-secrets/external-secrets/pull/3867](https://redirect.github.com/external-secrets/external-secrets/pull/3867) - Removed duplicate and deprecated API spec page by [@​7Pawns](https://redirect.github.com/7Pawns) in [https://github.com/external-secrets/external-secrets/pull/3868](https://redirect.github.com/external-secrets/external-secrets/pull/3868) - Delinea provider is listed twice on the documentation page, and Delin… by [@​oscerd](https://redirect.github.com/oscerd) in [https://github.com/external-secrets/external-secrets/pull/3874](https://redirect.github.com/external-secrets/external-secrets/pull/3874) - Updated supported versions table for 0.10 release by [@​shazib-summar](https://redirect.github.com/shazib-summar) in [https://github.com/external-secrets/external-secrets/pull/3873](https://redirect.github.com/external-secrets/external-secrets/pull/3873) - feat: adds scarf to docs by [@​gusfcarvalho](https://redirect.github.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3876](https://redirect.github.com/external-secrets/external-secrets/pull/3876) - docs: Update sponsors by [@​gusfcarvalho](https://redirect.github.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3877](https://redirect.github.com/external-secrets/external-secrets/pull/3877) - chore: add eso tools page by [@​Sn0rt](https://redirect.github.com/Sn0rt) in [https://github.com/external-secrets/external-secrets/pull/3870](https://redirect.github.com/external-secrets/external-secrets/pull/3870) - New Generator for UUIDs by [@​aschaber1](https://redirect.github.com/aschaber1) in [https://github.com/external-secrets/external-secrets/pull/3296](https://redirect.github.com/external-secrets/external-secrets/pull/3296) - fix: update uuids.generator shortname by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3883](https://redirect.github.com/external-secrets/external-secrets/pull/3883) - chore(deps): bump alpine from `0a4eaa0` to `beefdbd` in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3884](https://redirect.github.com/external-secrets/external-secrets/pull/3884) - chore(deps): bump alpine from `0a4eaa0` to `beefdbd` by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3886](https://redirect.github.com/external-secrets/external-secrets/pull/3886) - chore(deps): bump distroless/static from `ce46866` to `95eb83a` by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3887](https://redirect.github.com/external-secrets/external-secrets/pull/3887) - chore(deps): bump golang from 1.23.0 to 1.23.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3888](https://redirect.github.com/external-secrets/external-secrets/pull/3888) - chore(deps): bump golang from 1.23.0-bookworm to 1.23.1-bookworm in /e2e by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3889](https://redirect.github.com/external-secrets/external-secrets/pull/3889) - chore(deps): bump alpine from 3.20.2 to 3.20.3 in /e2e by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3890](https://redirect.github.com/external-secrets/external-secrets/pull/3890) - chore(deps): bump watchdog from 5.0.0 to 5.0.2 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3891](https://redirect.github.com/external-secrets/external-secrets/pull/3891) - chore(deps): bump platformdirs from 4.2.2 to 4.3.2 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3892](https://redirect.github.com/external-secrets/external-secrets/pull/3892) - chore: update dependencies by [@​eso-service-account-app](https://redirect.github.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3893](https://redirect.github.com/external-secrets/external-secrets/pull/3893) #### New Contributors - [@​stek29](https://redirect.github.com/stek29) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3838](https://redirect.github.com/external-secrets/external-secrets/pull/3838) - [@​sali2801](https://redirect.github.com/sali2801) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3867](https://redirect.github.com/external-secrets/external-secrets/pull/3867) - [@​7Pawns](https://redirect.github.com/7Pawns) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3868](https://redirect.github.com/external-secrets/external-secrets/pull/3868) - [@​oscerd](https://redirect.github.com/oscerd) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3874](https://redirect.github.com/external-secrets/external-secrets/pull/3874) - [@​Sn0rt](https://redirect.github.com/Sn0rt) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3870](https://redirect.github.com/external-secrets/external-secrets/pull/3870) **Full Changelog**: external-secrets/external-secrets@v0.10.2...v0.10.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Mi4xIiwidXBkYXRlZEluVmVyIjoiMzguNzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Sep 19, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://redirect.github.com/external-secrets/external-secrets) | patch | `0.10.2` -> `0.10.3` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.10.3`](https://redirect.github.com/external-secrets/external-secrets/releases/tag/v0.10.3) [Compare Source](https://redirect.github.com/external-secrets/external-secrets/compare/v0.10.2...v0.10.3) Image: `ghcr.io/external-secrets/external-secrets:v0.10.3` Image: `ghcr.io/external-secrets/external-secrets:v0.10.3-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.10.3-ubi-boringssl` #### What's Changed - release: update helm charts to version v0.10.2 by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3846](https://redirect.github.com/external-secrets/external-secrets/pull/3846) - Use Conjur API's built in JWT functions by [@​szh](https://redirect.github.com/szh) in [https://github.com/external-secrets/external-secrets/pull/3771](https://redirect.github.com/external-secrets/external-secrets/pull/3771) - fix: set grpc resolver explicitly in yandex by [@​stek29](https://redirect.github.com/stek29) in [https://github.com/external-secrets/external-secrets/pull/3838](https://redirect.github.com/external-secrets/external-secrets/pull/3838) - Add values.schema.json generation to Helm chart by [@​PrateekKumar1709](https://redirect.github.com/PrateekKumar1709) in [https://github.com/external-secrets/external-secrets/pull/3774](https://redirect.github.com/external-secrets/external-secrets/pull/3774) - fix: only replace data if it is in the middle of the path by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3852](https://redirect.github.com/external-secrets/external-secrets/pull/3852) - fix: bitwarden API url to point to the correct default location by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3848](https://redirect.github.com/external-secrets/external-secrets/pull/3848) - feat: update bitwarden server sdk chart version by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3850](https://redirect.github.com/external-secrets/external-secrets/pull/3850) - chore(deps): bump github/codeql-action from 3.26.5 to 3.26.6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3855](https://redirect.github.com/external-secrets/external-secrets/pull/3855) - chore(deps): bump actions/setup-python from 5.1.1 to 5.2.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3856](https://redirect.github.com/external-secrets/external-secrets/pull/3856) - chore(deps): bump mkdocs-material from 9.5.33 to 9.5.34 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3857](https://redirect.github.com/external-secrets/external-secrets/pull/3857) - chore(deps): bump mkdocs from 1.6.0 to 1.6.1 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3858](https://redirect.github.com/external-secrets/external-secrets/pull/3858) - chore(deps): bump watchdog from 4.0.2 to 5.0.0 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3861](https://redirect.github.com/external-secrets/external-secrets/pull/3861) - chore(deps): bump certifi from 2024.7.4 to 2024.8.30 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3859](https://redirect.github.com/external-secrets/external-secrets/pull/3859) - chore(deps): bump zipp from 3.20.0 to 3.20.1 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3860](https://redirect.github.com/external-secrets/external-secrets/pull/3860) - chore: update dependencies by [@​eso-service-account-app](https://redirect.github.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3862](https://redirect.github.com/external-secrets/external-secrets/pull/3862) - Add blog post about ESO and IBM Secrets Manager by [@​sali2801](https://redirect.github.com/sali2801) in [https://github.com/external-secrets/external-secrets/pull/3867](https://redirect.github.com/external-secrets/external-secrets/pull/3867) - Removed duplicate and deprecated API spec page by [@​7Pawns](https://redirect.github.com/7Pawns) in [https://github.com/external-secrets/external-secrets/pull/3868](https://redirect.github.com/external-secrets/external-secrets/pull/3868) - Delinea provider is listed twice on the documentation page, and Delin… by [@​oscerd](https://redirect.github.com/oscerd) in [https://github.com/external-secrets/external-secrets/pull/3874](https://redirect.github.com/external-secrets/external-secrets/pull/3874) - Updated supported versions table for 0.10 release by [@​shazib-summar](https://redirect.github.com/shazib-summar) in [https://github.com/external-secrets/external-secrets/pull/3873](https://redirect.github.com/external-secrets/external-secrets/pull/3873) - feat: adds scarf to docs by [@​gusfcarvalho](https://redirect.github.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3876](https://redirect.github.com/external-secrets/external-secrets/pull/3876) - docs: Update sponsors by [@​gusfcarvalho](https://redirect.github.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3877](https://redirect.github.com/external-secrets/external-secrets/pull/3877) - chore: add eso tools page by [@​Sn0rt](https://redirect.github.com/Sn0rt) in [https://github.com/external-secrets/external-secrets/pull/3870](https://redirect.github.com/external-secrets/external-secrets/pull/3870) - New Generator for UUIDs by [@​aschaber1](https://redirect.github.com/aschaber1) in [https://github.com/external-secrets/external-secrets/pull/3296](https://redirect.github.com/external-secrets/external-secrets/pull/3296) - fix: update uuids.generator shortname by [@​Skarlso](https://redirect.github.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3883](https://redirect.github.com/external-secrets/external-secrets/pull/3883) - chore(deps): bump alpine from `0a4eaa0` to `beefdbd` in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3884](https://redirect.github.com/external-secrets/external-secrets/pull/3884) - chore(deps): bump alpine from `0a4eaa0` to `beefdbd` by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3886](https://redirect.github.com/external-secrets/external-secrets/pull/3886) - chore(deps): bump distroless/static from `ce46866` to `95eb83a` by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3887](https://redirect.github.com/external-secrets/external-secrets/pull/3887) - chore(deps): bump golang from 1.23.0 to 1.23.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3888](https://redirect.github.com/external-secrets/external-secrets/pull/3888) - chore(deps): bump golang from 1.23.0-bookworm to 1.23.1-bookworm in /e2e by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3889](https://redirect.github.com/external-secrets/external-secrets/pull/3889) - chore(deps): bump alpine from 3.20.2 to 3.20.3 in /e2e by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3890](https://redirect.github.com/external-secrets/external-secrets/pull/3890) - chore(deps): bump watchdog from 5.0.0 to 5.0.2 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3891](https://redirect.github.com/external-secrets/external-secrets/pull/3891) - chore(deps): bump platformdirs from 4.2.2 to 4.3.2 in /hack/api-docs by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3892](https://redirect.github.com/external-secrets/external-secrets/pull/3892) - chore: update dependencies by [@​eso-service-account-app](https://redirect.github.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3893](https://redirect.github.com/external-secrets/external-secrets/pull/3893) #### New Contributors - [@​stek29](https://redirect.github.com/stek29) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3838](https://redirect.github.com/external-secrets/external-secrets/pull/3838) - [@​sali2801](https://redirect.github.com/sali2801) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3867](https://redirect.github.com/external-secrets/external-secrets/pull/3867) - [@​7Pawns](https://redirect.github.com/7Pawns) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3868](https://redirect.github.com/external-secrets/external-secrets/pull/3868) - [@​oscerd](https://redirect.github.com/oscerd) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3874](https://redirect.github.com/external-secrets/external-secrets/pull/3874) - [@​Sn0rt](https://redirect.github.com/Sn0rt) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3870](https://redirect.github.com/external-secrets/external-secrets/pull/3870) **Full Changelog**: external-secrets/external-secrets@v0.10.2...v0.10.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Mi4xIiwidXBkYXRlZEluVmVyIjoiMzguNzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
The ESO Helm chart currently lacks a values.schema.json file, which is necessary for tools that render UIs for Helm charts based on their schema. This absence makes it difficult for users to validate their values.yaml files and for tools to provide a user-friendly interface for configuring the Helm chart.
Related Issue
Fixes #3642
Proposed Changes
How do you like to solve the issue and why?
To solve this issue, I propose using the Helm Values Schema JSON Plugin to generate a values.schema.json file from the existing values.yaml file. This approach automates the schema generation process, ensuring that the schema is always up-to-date with minimal maintenance effort. The generated schema will include a basic set of fields that users typically update, providing a balance between usability and maintainability.
The changes include:
Checklist
git commit --signoffmake testmake reviewable