Skip to content

ENH: Add img-alt for card and grid-item-card#114

Merged
choldgraf merged 2 commits intoexecutablebooks:mainfrom
jpmckinney:108-add-img-alt
Apr 13, 2023
Merged

ENH: Add img-alt for card and grid-item-card#114
choldgraf merged 2 commits intoexecutablebooks:mainfrom
jpmckinney:108-add-img-alt

Conversation

@jpmckinney
Copy link
Copy Markdown
Contributor

@jpmckinney jpmckinney commented Dec 8, 2022 •
edited
Loading

closes #33
closes #108

@jpmckinney jpmckinney mentioned this pull request Dec 8, 2022
Closed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (d19e589) 89.96% compared to head (fa342ed) 90.05%.

❗ Current head fa342ed differs from pull request most recent head 9db2af4. Consider uploading reports for the commit 9db2af4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   89.96%   90.05%   +0.08%     
==========================================
  Files          11       10       -1     
  Lines         947      935      -12     
==========================================
- Hits          852      842      -10     
+ Misses         95       93       -2
Flag Coverage Δ
pytests 90.05% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_design/grids.py 87.91% <ø> (-0.14%) ⬇️
sphinx_design/cards.py 95.48% <100.00%> (+0.03%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

choldgraf
choldgraf approved these changes Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one - thanks @jpmckinney , it looks good to me, and appreciate you updating the tests as well 👍

@choldgraf choldgraf changed the title feat: Add img-alt for card (and grid-item-card) ENH: Add img-alt for card and grid-item-card Apr 13, 2023
@choldgraf choldgraf merged commit 3841eaa into executablebooks:main Apr 13, 2023
@choldgraf choldgraf mentioned this pull request Apr 13, 2023
Merged
@jpmckinney jpmckinney deleted the 108-add-img-alt branch April 13, 2023 17:18
@chrisjsewell chrisjsewell mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option img-alt for card Functionality/documentation for adding alt text to image labels

3 participants

@jpmckinney @codecov-commenter @choldgraf