MAINT: Update pre-commit versions and fix minor bugs in tests#660
Merged
choldgraf merged 5 commits intoexecutablebooks:masterfrom Dec 14, 2022
Merged
MAINT: Update pre-commit versions and fix minor bugs in tests#660choldgraf merged 5 commits intoexecutablebooks:masterfrom
choldgraf merged 5 commits intoexecutablebooks:masterfrom
Conversation
Member
Author
|
Going to self-merge this one because it's just a minor fix to get our tests passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems that don't have the right version of GLIBC installed pre-commit will not work because of a missing dependency as described in this SO post:
This fixes the version of node that is used so that this issue doesn't pop up, as per the guidelines in that issue.
It also avoids
ipython==8.7.0in our tests to stop having a lexer bug that it introduced.I'll merge this one quickly so that we can fix pre-commit and get our tests passing.