MAINT: Factor publish to pypi workflow into dedicated file#645
Merged
choldgraf merged 2 commits intoexecutablebooks:masterfrom Nov 25, 2022
Merged
MAINT: Factor publish to pypi workflow into dedicated file#645choldgraf merged 2 commits intoexecutablebooks:masterfrom
choldgraf merged 2 commits intoexecutablebooks:masterfrom
Conversation
AakashGfude
reviewed
Nov 25, 2022
| uses: ./.github/workflows/tests.yml | ||
| publish: | ||
| name: publish | ||
| needs: [tests] # require tests to pass before deploy runs |
Member
There was a problem hiding this comment.
Do we also need 'docs-audit' here, or 'tests' is good enough you think?
Member
Author
There was a problem hiding this comment.
This will run all of the jobs that are in that workflow file, so it'll run docs-audit as well 👍
AakashGfude
approved these changes
Nov 25, 2022
Member
AakashGfude
left a comment
There was a problem hiding this comment.
Thanks @choldgraf for this feature. Looks good to me. Apart from one comment above.
Member
Author
|
thanks for the approve @AakashGfude - I think those two unreported tests are bugs in github not due to these changes, so lemme merge and see if that resolves it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have a workflow embedded in
tests.ymlthat is called only if a new release is made. However this shows us as "not run" in our test suite in github and messes with the passing tests condition.This PR factors that out into a dedicated workflow file that is run on
publishand calls our test suite before running the publish command. That should mean the "Publish to PyPI" action never gets run unless we are publishing.cc @AakashGfude this should make it easier to quickly see if the tests are happy in PRs