ENH: Allowing inline elements in sidenotes and marginnotes#641
Merged
AakashGfude merged 5 commits intomasterfrom Nov 8, 2022
Merged
ENH: Allowing inline elements in sidenotes and marginnotes#641AakashGfude merged 5 commits intomasterfrom
AakashGfude merged 5 commits intomasterfrom
Conversation
choldgraf
reviewed
Nov 8, 2022
Member
choldgraf
left a comment
There was a problem hiding this comment.
Looks like a nice implementation to me - can you see what's up w/ the tests?
choldgraf
approved these changes
Nov 8, 2022
Member
choldgraf
left a comment
There was a problem hiding this comment.
This looks good to me - thanks for fixing it up!
Member
Author
|
Thanks @choldgraf for the review. I will merge this one, once rest of the tests are done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #612