MAINT: remove incorrect comment from sphinx pin.#588
Merged
choldgraf merged 1 commit intoexecutablebooks:masterfrom Jul 19, 2022
Merged
MAINT: remove incorrect comment from sphinx pin.#588choldgraf merged 1 commit intoexecutablebooks:masterfrom
choldgraf merged 1 commit intoexecutablebooks:masterfrom
Conversation
The comment here was out-of-date (sphinx 5 has been released) which made it unclear whether the pin was intentional or an error. From the discussion in executablebooksgh-583, it's now clear the pin is intentional, so removing the comment for clarity. Alternatively, the comment could be updated in a way that won't be obsoleted by future sphinx releases - wording suggestions welcome.
Member
|
Hmmm do things build as expected if you just remove it? Maybe this is old cruft from the past? |
Member
|
I think we'd need to update the footnotes CSS for Sphinx 5 -- that's all. |
choldgraf
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment here was out-of-date (sphinx 5 has been released)
which made it unclear whether the pin was intentional or an
error. From the discussion in gh-583, it's now clear the pin
is intentional, so removing the comment for clarity.
Alternatively, the comment could be updated in a way that won't
be obsoleted by future sphinx releases - wording suggestions
welcome.
Closes #583