Skip to content

BUG: fix for pydata-sphinx-theme>=0.13.3#714

Merged
AakashGfude merged 1 commit intoexecutablebooks:masterfrom
jakevdp:fix-pydata-sphinx-theme
Mar 31, 2023
Merged

BUG: fix for pydata-sphinx-theme>=0.13.3#714
AakashGfude merged 1 commit intoexecutablebooks:masterfrom
jakevdp:fix-pydata-sphinx-theme

Conversation

@jakevdp
Copy link
Copy Markdown
Contributor

@jakevdp jakevdp commented Mar 30, 2023 •
edited
Loading

Fixes #711 by pinning to pydata-sphinx-theme>=0.13.3 and using the new pydata_sphinx_theme.utils submodule

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 30, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@jakevdp jakevdp force-pushed the fix-pydata-sphinx-theme branch from 4eff992 to 7af0828 Compare March 30, 2023 22:27
@jakevdp jakevdp changed the title BUG: make compatible with pydata-sphinx-theme 0.13.2 BUG: make compatible with pydata-sphinx-theme 0.13.3 Mar 30, 2023
@jakevdp jakevdp force-pushed the fix-pydata-sphinx-theme branch from 7af0828 to 1eddf3f Compare March 30, 2023 22:31
@jakevdp jakevdp changed the title BUG: make compatible with pydata-sphinx-theme 0.13.3 BUG: fix for pydata-sphinx-theme>=0.13.3 Mar 30, 2023
@mmcky mmcky requested a review from AakashGfude March 31, 2023 00:30
@mmcky
Copy link
Copy Markdown
Member

mmcky commented Mar 31, 2023 •
edited
Loading

thanks @jakevdp for this PR.

@AakashGfude this looks good to me but not overly familiar with the code base. Could you please review this and organise a new release? Thanks.

@AakashGfude
Copy link
Copy Markdown
Member

AakashGfude commented Mar 31, 2023

Thanks @jakevdp , this is awesome. I noticed a few UI issues which I have listed here: #715 . I will merge this, fix them, and cut a release.

@AakashGfude AakashGfude merged commit 78bde16 into executablebooks:master Mar 31, 2023
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 31, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@Saksham-13
Copy link
Copy Markdown

Saksham-13 commented Mar 31, 2023

Thanks @jakevdp , this is awesome. I noticed a few UI issues which I have listed here: #715 . I will merge this, fix them, and cut a release.

hey, by when will this be released?

This was referenced Mar 31, 2023
Closed
Closed
@mauritsvanrees
Copy link
Copy Markdown

mauritsvanrees commented Mar 31, 2023

I confirm that version 1.0.1 fixes this. Thanks!

@jakevdp jakevdp deleted the fix-pydata-sphinx-theme branch March 31, 2023 15:10
@jakevdp
Copy link
Copy Markdown
Contributor Author

jakevdp commented Mar 31, 2023

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AakashGfude AakashGfude AakashGfude approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pydata-sphinx-theme 0.13.2 breaks sphinx-book-theme

5 participants

@jakevdp @mmcky @AakashGfude @Saksham-13 @mauritsvanrees